Global font - Open Sans - Latin-Extended

[novami]

Hi guys,

First thank you very much for the amazing job, what you have done on Nextcloud!

I've found a little problem, it looks like global font Open Sans is not loaded with parameter Latin-Extended and this makes some letters damaged in my nattive language and I'm pretty sure that in other languages too.

It would be nice to have a possibility to specify (in the theme settings) Google font url in one form input e.g. "https://fonts.googleapis.com/css?family=Roboto&subset=latin-ext" and global font name like "Roboto" in second input. Do it and you'll make a lot of users happier ;-).

I know that this is a minor issue and a lot of people don't care about it, but there is quite easy solution, isn't it? :-)

Thanks!

[nextcloud-bot]

GitMate.io thinks possibly related issues are #8509 (Add Open Sans fonts WOFF2 file format), #4781 (global addressbook), #140 (Global OAuth Configuration), #9422 (Set up Global categories as DAV item), and #2016 (Global / per disk quota).

[MorrisJobke]

It would be nice to have a possibility to specify (in the theme settings) Google font url in one form input e.g. "https://fonts.googleapis.com/css?family=Roboto&subset=latin-ext" and global font name like "Roboto" in second input. Do it and you'll make a lot of users happier ;-).

It should work out of the box without the need to configure anything. @jancborchardt @skjnldsv Do you think this is possible?

[skjnldsv]

@MorrisJobke loading external fonts is against our csp, right?

[ghost]

Aha, I understand, so make it easier and just let users to decide If the default font should be loaded as Latin-Extended or not in the theme settings (of course you have to include latin-ext font file into the Nexcloud package).

[MorrisJobke]

@MorrisJobke loading external fonts is against our csp, right?

But we can include it into our archive (we did this in the past as well).

Aha, I understand, so make it easier and just let users to decide If the default font should be loaded as Latin-Extended or not in the theme settings (of course you have to include latin-ext font file into the Nexcloud package).

I would not make it an option. We should just load all the needed font files that include everything.

[jancborchardt]

@novami @MicNov could you post a screenshot? Also, does not even the latest version of Open Sans (from Google Fonts) fix that?

[novami]

Sure, no problem - https://screenshots.firefox.com/iyJESBYUJ6k95AXy/disk.csy.cz and https://screenshots.firefox.com/i8s40Gq3SxBXNfnt/disk.csy.cz

I've marked some problematic letters.

I've several projects based on Open Sans too and If I use recomanded css link into header, with latin-ext, each letter looks good.

[MorrisJobke]

I've several projects based on Open Sans too and If I use recomanded css link into header, with latin-ext, each letter looks good.

I guess we need to fetch then those files and use them.

[jancborchardt]

Ok, so using this https://fonts.googleapis.com/css?family=Open%20Sans&subset=latin-ext should work? Any chance you can try if that fixes it for you locally @novami @MicNov?

[novami]

Yes, I've tested it locally and it works, but I just had to temporary disable CSP in Firefox...

[jancborchardt]

Awesome, thanks for testing! :) Do you also want to do the actual change? The file to edit is:

• fonts.scss: https://github.com/nextcloud/server/blob/master/core/css/fonts.scss
• And then probably also download current Open Sans and save the Light, Regular, Semibold and Bold (the ones we use) to the https://github.com/nextcloud/server/tree/master/core/fonts folder.

[novami]

I'm not sure how to do it correctly, but I think that just update of current font files should be enough. Question is how to get woff files - Google offers just ttf...

[MorrisJobke]

See also #11640 for Chinese font issues

[violoncelloCH]

is this one fixed by #11932 or is there something left I could do?
#11932 at least adds latin-ext fonts...

[MorrisJobke]

is this one fixed by #11932 or is there something left I could do?

This one is the fix for master, which will result in the next major version: 15.

@novami Is it fine for you to wait for 15 which is planned for December?

[novami]

@MorrisJobke Sure, December sounds good, thank you! 👍

[jancborchardt]

Closing this then. :)