Comments sent for a file before changing to another one may be shown in the new one

[danxuliu]

Note that the comment is actually stored in the server in the proper file; the problem is only related to the visualization of the comment in the browser.

When opening the details view for a different file CommentsTabView.setFileInfo is called. Although this resets the collection and thus removes the existing models/comments, reset does not abort the current pending requests (see pull 1325 in https://github.com/jashkenas/backbone (I am not linking it directly to prevent the reference from polluting that thread)). Thus, when the response for the creation of a new message is received it is handled in the regular way, that is, adding the model for the new comment to the collection, which causes it to be rendered in the list of comments, even if the request was originally done before the collection was reset.

@nextcloud/javascript

How to test:

• Make fetching comments a bit slower by adding sleep(3) to the beginning of getChild() in apps/dav/lib/Comments/RootCollection.php
• Open the Files app
• Create two files (or folders)
• Open the Comments tab in the details view for the first file
• Send a new comment
• Open the details view for the other file immediately after sending the comment, without waiting for it to be shown for the first file

Expected result:
The No comments yet message is eventually shown

Actual result:
The first message is eventually shown, even if the current file is the second one

[nextcloud-bot]

GitMate.io thinks possibly related issues are #4363 (Conflict dialogue doesn't show preview for new file any more), #1583 (occ files:scan -all Makes all folders show that they were just changed.), #8012 (Add an option to change or remove default new profile files), #11115 (Recopy should provide Skip all existing file and copy new one), and #7414 (Input field for comments no longer shows warnings about comment length).

[szaimen]

Hi, please update to 24.0.8 or better 25.0.2 and report back if it fixes the issue. Thank you!