Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Set your password" text on button in welcome mail out of bounds #13287

Closed
clesmian opened this issue Dec 29, 2018 · 9 comments · Fixed by #20447, #20386 or #20506
Closed

"Set your password" text on button in welcome mail out of bounds #13287

clesmian opened this issue Dec 29, 2018 · 9 comments · Fixed by #20447, #20386 or #20506
Labels
1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc. feature: emails good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@clesmian
Copy link

clesmian commented Dec 29, 2018

Steps to reproduce

  1. Set your language for example to German
  2. Set the name of your installation to a long name, using the Theming app
  3. Add a new user with an e-mail address, but without a password
  4. Wait for the first welcome mail to arrive
  5. Resend welcome mail using the option in the users panel

Expected behaviour
The welcome mail should be well formatted and the text inside of the buttons should stay inside of the buttons bounds.

Actual behaviour
The text inside of the left button exceeds the boundaries of the button.

Server configuration
Nextcloud version: 14.0.4

Examples can be found below. I have verified the formatting of the mail using Thunderbird and different webmail applications like roundcube.

welcome-mail-passwort-reset
First welcome mail

welcome-mail-long-instance-name
Resent welcome mail

@level420
Copy link

level420 commented Jan 2, 2019

@clesmian off topic question: does the "set your password" link work for your installation? It's not working in my installation. See #12527

I'm also observing that text overflow you've reported btw.

@clesmian
Copy link
Author

clesmian commented Jan 2, 2019

@level420 the link works for me.

@johanehnberg
Copy link

johanehnberg commented Jan 25, 2019

I can confirm this bug, it occurs also on 15.0.2 with default settings and English.

@skjnldsv skjnldsv added 0. Needs triage Pending check for reproducibility or if it fits our roadmap 1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc. and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jun 12, 2019
@tobyps
Copy link

tobyps commented Jul 10, 2019

Hi,
I have the same Issue with 15.0.10 and posted it on the forum.

In my case it had no problems in English, only in German.
But it seems also connected to the used Mailapp.

Thunderbird 60.8 produced the error. Another user tried it with Outlook 2010 and reported no problem.
Webmailers of T-Online and GMX also had the error.

@fuanegua
Copy link

Changing max-height of the button from 40px to 60px should do it.

@mroesele
Copy link

can confirm that this bug still exists

@kesselb
Copy link
Contributor

kesselb commented Jan 16, 2020

cc @nextcloud/designers

@juliusknorr juliusknorr added the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label Jan 24, 2020
liamjack added a commit to liamjack/server that referenced this issue Apr 12, 2020
…template

Signed-off-by: Liam JACK <liamjack@users.noreply.github.com>
liamjack added a commit to liamjack/server that referenced this issue Apr 12, 2020
…template

Signed-off-by: Liam JACK <liamjack@users.noreply.github.com>
@rullzer rullzer mentioned this issue Apr 13, 2020
59 tasks
@klemens-u
Copy link

Please fix this ugly layout issue. For many people the welcome mail is the first contact with Nextcloud ever. So this should be "pippifein" perfect and give a nice feeling to new users.

This was referenced Apr 15, 2020
@MorrisJobke
Copy link
Member

Wrongly closed - reopen.

@MorrisJobke MorrisJobke reopened this Apr 17, 2020
backportbot-nextcloud bot pushed a commit that referenced this issue Jun 12, 2020
Signed-off-by: Liam JACK <liamjack@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc. feature: emails good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet