Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readfilePart function defaults to 8kb #16945

Closed
exussum12 opened this issue Aug 30, 2019 · 2 comments
Closed

readfilePart function defaults to 8kb #16945

exussum12 opened this issue Aug 30, 2019 · 2 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug

Comments

@exussum12
Copy link
Contributor

exussum12 commented Aug 30, 2019

Steps to reproduce

  1. Set up the data dir to be over NFS (defaults are fine)
  2. Watch a large video though the interface

Expected behaviour

NFS server sends {video size} data

Actual behaviour

NFS server sends WAY more data than needed,
rsize=65536,wsize=65536 (chosen automatically by nfs server) - the function sends 65k when 8k is read, then next 8k requested = another 65k being sent.

Server configuration

Operating system:
Linux
Web server:
Nignx
Database:
MySQL
PHP version:
7.3
Nextcloud version: (see Nextcloud admin page)
Master
Updated from an older Nextcloud/ownCloud or fresh install:
Doesnt matter
Where did you install Nextcloud from:
Github

Are you using external storage, if yes which one: nfs (but looks local from nextclouds POV)

Are you using encryption: no

The code reads $chunkSize = 8192; // 8 kB chunks

Just wondering why that was a default ? I assume as that is the safe bet for TCP ?

If it is for TCP we should set to the max size on the system falling back to 8192.

If TCP is never involved this is purely a memory based setting, maybe setting to 1mb or so.

Any thoughts on this ?

@exussum12 exussum12 added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Aug 30, 2019
@szaimen
Copy link
Contributor

szaimen commented May 26, 2021

I'm closing this issue due to inactivity. If this is still happening please make sure to upgrade to the latest version. After that, feel free to reopen.

@szaimen szaimen closed this as completed May 26, 2021
@exussum12
Copy link
Contributor Author

Sorry not sure why this didnt auto close, I submitted a PR which was merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug
Projects
None yet
Development

No branches or pull requests

2 participants