Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group list is overlapping if you are part of too many groups #18920

Closed
nickvergessen opened this issue Jan 16, 2020 · 19 comments · Fixed by #19533
Closed

Group list is overlapping if you are part of too many groups #18920

nickvergessen opened this issue Jan 16, 2020 · 19 comments · Fixed by #19533
Assignees
Labels

Comments

@nickvergessen
Copy link
Member

Bildschirmfoto von 2020-01-16 09-46-57

cc @GretaD

@nickvergessen nickvergessen added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap feature: users and groups labels Jan 16, 2020
@GretaD
Copy link
Contributor

GretaD commented Jan 17, 2020

@nextcloud/designers how to move on with this one? How about we show first 3 and the rest with a tooltip when you hover?

@Luticus
Copy link

Luticus commented Jan 19, 2020

From an outside perspective maybe add a small down arrow like feature to the right of lists that overflow. When you click the list or the arrow it will show an expanded list via a drop down similar to what happens when you click the [...] menu on the right. Probably should make all the items in that list be one per line though unlike how they are presented in the main view. Alternatively, instead of the down arrow you could print an ellipsis at the end of the list in the main view that indicates the list is truncated and then when you click the list you get a drop down showing the full list.

@cfranz
Copy link

cfranz commented Jan 21, 2020

I have to report another issue regarding the list of users. When editing a user and trying to choose the groups assigned to a user, the dropdown is behind the row of the users below.

I've added a screenshot to show the issue:

nextcloud-edit-user-groups

@GretaD
Copy link
Contributor

GretaD commented Jan 28, 2020

while on editing mode, all the multiselect elements are overlapping

@maximiliancs
Copy link

While fixing this bug it could be useful to overthink the general user experience when managing the user's groups. If there are many groups in the list, it's really horrible to scroll through the small tooltip, especially when changing user groups on the go on mobile devices (e.g. iPad). A pop up window would with a list of all groups and a search option would be nice.

Besides that the user management could see improvements from a security standpoint of view. There should be more user roles to select from or specific settings admins can make. At the moment there are only admins, users with more rights within their user group and normal users. There should be more individual settings which for example deactivates changing of user's password or deactivating accounts when not being an admin. There are many more features that could be implemented here to make nextcloud even more better than it is now. However this is probably not the right post for it.

@nickvergessen nickvergessen added 1. to develop Accepted and waiting to be taken care of regression and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jan 31, 2020
@JohanBoshoffWebAware
Copy link

If there is any custom css we can implement to fix this overlapping, please post it here. It is really confusing with the overlapping.

I suggest there should be a default background color implemented so that the overlapping parts is not visible. I have tried with the custom CSS but it does not work.

This is the CSS that needs changing and works in the browser element:

.multiselect[data-v-764bdcc] .multiselect__content-wrapper .multiselect__content {
background-color: white;
}

.multiselect__content-wrapper li {
background-color: white;
}

.multiselect__content-wrapper {
background-color: white;
}

However, in custom CSS this gets ignored.

@awesome-michael
Copy link

Kind of works if grid-auto-rows: 60px; is deleted from #body-settings #app-content.user-list-grid. Just fiddled a bit with the developer tools of my browser.

@RailsViceRoads
Copy link

RailsViceRoads commented Feb 18, 2020

Found the same behaviour in users view, if the column group administrator contains a huge number of groups. NC Version is 18.0.1
In this case, the content of the whole row will moved in the next users line.
grafik

@p5n
Copy link
Contributor

p5n commented Feb 27, 2020

I patched 18.0.1 with diff between stable18 and v18.0.1 and it does not look fixed.

@nickvergessen
Copy link
Member Author

Did you also update the compiled JS files?

@DBJRdev
Copy link

DBJRdev commented Mar 10, 2020

After upgrading our test instance to 18.0.2RC2, I realized that the appearance problem is only visible for the first couple of users, because the dropdown for groups really appears downards. If you try to edit a user who's later in the list, the group dropdown appears above the user and you can edit the user's groups without problems – all looks nice there. See the comparison here:
Bildschirmfoto von 2020-03-10 12-22-01
last user

@DBJRdev
Copy link

DBJRdev commented Mar 10, 2020

@ChristophWurst @juliushaertl Please reopen, as the issue is only partly fixed

@skjnldsv
Copy link
Member

@DBJRdev did you tried the fixes?

@JohanBoshoffWebAware
Copy link

Please could you send me the fixes as I cannot see from the list what has been fixed. I cannot seem to get it working.

@DBJRdev
Copy link

DBJRdev commented Mar 10, 2020

@skjnldsv : Uhm, I don't know what fixes I am supposed to include, I just used the totally fresh 18.0.2RC2 from yesterday evening, assuming the 18 day old closing of the issue had the solution in. Please give me a hint and I will follow you to give better feedback :)

@skjnldsv
Copy link
Member

This is inplemented in upcomming 18 release (18.0.2)
Please try the RC version if you're confident enough or wait for upcoming release

@JohanBoshoffWebAware
Copy link

Thanks. Will wait for the upcoming stable release

@andreazaupa
Copy link

andreazaupa commented Mar 17, 2020

Little custom css fix (waiting for 18.0.2) .

#body-settings #app-content.user-list-grid{ display: block; }

#body-settings #app-content.user-list-grid .row > div.userActions .toggleUserActions, #body-settings #app-content.user-list-grid .row > form.userActions .toggleUserActions{background: #fff;}

I dont know if there is some side effect, only the first directive is necessary to fix.

@JohanBoshoffWebAware
Copy link

Your custom CSS works perfectly! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.