Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in:users as a search filter to limit searches to users #40287

Closed
AndyScherzinger opened this issue Sep 6, 2023 · 1 comment · Fixed by #40413
Closed

Add in:users as a search filter to limit searches to users #40287

AndyScherzinger opened this issue Sep 6, 2023 · 1 comment · Fixed by #40413

Comments

@AndyScherzinger
Copy link
Member

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
Currently when you have large installation in terms of users and you need to search for a user, you can only do that via unified search. This works and filters down the list of users in case you are at */settings/users on your instance. The downside is that this then also trigger searches in all available search providers.

Describe the solution you'd like
Provide a app-filter in:users that can be added to the search query like it can be done for other apps like files and within the actual user search just remove any occurrence of in:users and just search with the rest of the search string (trimmed). Due to the in-filter all search providers will be skipped which is what is the desired behavior.

Describe alternatives you've considered
Implement an in-app search in users like present in talk but that would be way more work.


This shall be backported down to v25

@AndyScherzinger AndyScherzinger added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Sep 6, 2023
@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Sep 6, 2023
@AndyScherzinger AndyScherzinger moved this to 📄 To do (~10 entries) in 📁 Files team Sep 6, 2023
@AndyScherzinger AndyScherzinger moved this from 📄 To do (~10 entries) to 🧭 Planning evaluation (don't pick) in 📁 Files team Sep 6, 2023
@AndyScherzinger AndyScherzinger moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 📁 Files team Sep 7, 2023
@AndyScherzinger AndyScherzinger added 2. developing Work in progress backport-request and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Sep 7, 2023
@sorbaugh
Copy link
Contributor

sorbaugh commented Sep 13, 2023

Update. Original solution included a User search result list in the search dialog. However, expected behavior still unclear about what should happen when we click on a user (among other things). So we decided to reduce the scope to the original intent of this issue and just add the SearchProvider to have the in:users filter and revisit adding the search result list and how it should behave with a new issue.

EDIT: Will create new commit instead of ammend for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants