Beta design feedback

[jancborchardt]

Discussed with @karlitschek and @marcoambrosini. cc @AndyScherzinger for awareness. Sorted by priority of visual impact.

Since we are in the beta stage and already beyond feature freeze, we need to focus on easy fixes.

1. Sidebar tabs too present and conflict with primary buttons, especially in Talk: Style will be changed from full primary background highlight to underline. → FIX at Fix tabs appearance nextcloud-libraries/nextcloud-vue#4815
2. Share button too present: Style change to tertiary non-bold button (background will be removed and color adjusted to color-primary-element). → FIX at Improve shared status button #41453
3. Groupfolder and other folder icons are off: There is a dark icon with white stroke on color-primary icon. Instead icon should simply be color-primary-element-text on the color-primary-element icon – same logic as the primary button. → FIX at fix(files): Use color-primary-element-text for files/folders overlay icons #41455
4. Favorites button in sidebar overlaps icon/preview too much: "Favorite" can move to actions menu, and indicator to start of subline with size and modified date. Enh/beta improvements #41481
5. Comments layout improvements: Vertically align name with avatar, remove "" quotes so subline does not wrap. Enh/beta improvements #41481

Additional second set of feedback:

1. Black border in "New" menu in Safari: There is a black border on the first entry of the "New" menu. It should only appear on tab navigation, not on initial opening or interacting with the mouse. → Bug with Safari, does not appear with Chrome. @ShGKme can reproduce
   Issue: Outline from :focus-visible on NcAction* items shows when it is not supposed to in Safari 🍏 nextcloud-libraries/nextcloud-vue#4874
2. Some action menus have scrollbars: Issue exists at Menus do not show completely even if there is vertical space, always restricted to 50% nextcloud-libraries/nextcloud-vue#3920 → According to @marcoambrosini @szaimen very complicated as the component would need logic to know where it is opened. Currently always 50vh to work in all circumstances.
3. Time of calendar notification is based on first of a recurring meeting: The time in the notification should be based on the next meeting and not the first of a recurring event. → Christoph opened issue at [Bug]: Wrong relative time for events in caldav push notifications #41615
4. External storage settings layout looks off: Should be on top of the page, or properly integrated into emptycontent view → @marcoambrosini @szaimen [Bug]: External storage settings layout is mixed emptycontent + actual interface #41614
5. "Shared" label takes a lot of space in Files list for internal shares: → Proposals at "Shared" label takes a lot of space in Files list #41620 Show shared label only if the current user have shared the file. #41656

Some more feedback from Jan:

• Background of favorite star border has different color on hover nextcloud-libraries/nextcloud-vue#4872
• Top and bottom padding of action menu too much, does not match sides nextcloud-libraries/nextcloud-vue#4870 → pull request at Remove server styles from action menu nextcloud-libraries/nextcloud-vue#4875
• Too much focus on the file list headings nextcloud-libraries/nextcloud-vue#4871

[jancborchardt]

Issue for "Move or copy" opened at #41661, let’s keep the discussion over there since as said it’s not a design issue.

[jospoortvliet]

Maybe this is also something: #42098 -> the right click menu opening far from the cursor.

[jancborchardt]

@AndyScherzinger @sorbaugh since there are only 2 issues remaining here, I would suggest scheduling those for the next Files cycle specifically and closing this issue so they don’t get lost.

[AndyScherzinger]

Sounds good to me, can you take care of it @sorbaugh

[jancborchardt]

Closing this then as we have follow-up issues. cc @sorbaugh for the scheduling – the menu scroll one I have noted for the next planning meeting from my side.