Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Cannot search in users management page with global search enabled #41484

Closed
7 of 8 tasks
blizzz opened this issue Nov 15, 2023 · 10 comments
Closed
7 of 8 tasks

[Bug]: Cannot search in users management page with global search enabled #41484

blizzz opened this issue Nov 15, 2023 · 10 comments
Assignees
Labels
Milestone

Comments

@blizzz
Copy link
Member

blizzz commented Nov 15, 2023

⚠️ This issue respects the following points: ⚠️

Bug description

With global search enabled and on the users page, the list of users cannot be filtered anymore. When clicking "people" on the global search, and looking for a users, they are not found either. Also the duplicated input box is confusing.

global.search.vs.user.mgmt.webm

Steps to reproduce

  1. Have global search enabled
  2. go to users page
  3. try to search for a user

Expected behavior

A search for the entered string is performed and only matching users are shown. As it happens with old search.

Installation method

None

Nextcloud Server version

master

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@blizzz blizzz added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap 28-feedback regression feature: search labels Nov 15, 2023
@blizzz
Copy link
Member Author

blizzz commented Nov 15, 2023

cc @fenn-cs @Altahrim

@Altahrim
Copy link
Collaborator

@blizzz
Copy link
Member Author

blizzz commented Nov 15, 2023

It seems the user search provider is a bit incomplete: https://github.com/nextcloud/server/blob/master/apps/settings/lib/Search/UserSearch.php#L72-L75

Related comment: #40413 (comment)

@AndyScherzinger
Copy link
Member

Yeah, the user search works slightly different and doesn't forward results into the unified search or new advanced search.

Can you still trigger the original behavior for user searches @Altahrim @fenn-cs

@AndyScherzinger
Copy link
Member

  • Only show "USERS" as a app-filter when being on the user-management page
  • emit the unified search event

@ChristophWurst
Copy link
Member

App management search doesn't work either. Same issue?

@Altahrim
Copy link
Collaborator

Altahrim commented Nov 30, 2023

App management search doesn't work either. Same issue?

Yes :)
Should be fixed with #41669. Not the best way but it will search in background.

@ChristophWurst
Copy link
Member

Should be fixed with #41669.

I still can't search on latest master

@blizzz
Copy link
Member Author

blizzz commented Dec 1, 2023

Searching works now on RC2 albeit the UX is suboptimal. The modal is shown and active, and also gets search results from other sources, but the actual user search results appear in the background.

@AndyScherzinger AndyScherzinger moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Dec 1, 2023
@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Dec 1, 2023
@AndyScherzinger
Copy link
Member

So yeah, fixed for the moment while UX is not optimal, yet it works the way it did before except the modal is larger than the former popup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

5 participants