Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV] 9.1.4.1/8.1 - NcTimezonePicker group headings / continents groupings do not meet contrast ratio (1.1:1 instead of the 3:1 contrast ratio that is required) #41842

Closed
JuliaKirschenheuter opened this issue Nov 29, 2023 · 14 comments
Assignees
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility enhancement
Milestone

Comments

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Nov 29, 2023

image

https://report.bitvtest.de/default-en/cbedb5ef-4815-4cba-a83d-995599c178c3.html#checkpoint-45ae33ca9f-v8-n1

The headers / Continent of the grouped areas in the NcTimezonePicker are visually marked by a light gray background (1,1:1 to white) and remain below the contrast ratio of 3:1 that is needed to indicate the state visually.

@JuliaKirschenheuter JuliaKirschenheuter added 1. to develop Accepted and waiting to be taken care of accessibility labels Nov 29, 2023
@susnux susnux self-assigned this Nov 30, 2023
@susnux
Copy link
Contributor

susnux commented Dec 6, 2023

This is not the active element but a "heading" to group the timezones by continents.

cc @JuliaKirschenheuter

@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Dec 7, 2023

Asked designers but would prefer to remove all groups because it has only a decorative "function"

@JuliaKirschenheuter
Copy link
Contributor Author

From design channel:
If we would just remove the groups then we would have a problem with ambiguous regions. e.g. /Eastern https://en.wikipedia.org/wiki/List_of_tz_database_time_zones

we could also flatten the structure to Europe/Berlin and remove all groups.
@susnux would you say it is a easy way?

@susnux
Copy link
Contributor

susnux commented Dec 7, 2023

My idea was to either have two boxes or to allow to select regions for filtering. E.g. Europe and then you can select the zone e.g. Berlin within the same box.
While still allowing to select Europe/Berlin directly.

@susnux
Copy link
Contributor

susnux commented Dec 7, 2023

If we would just remove the groups then we would have a problem with ambiguous regions. e.g. /Eastern https://en.wikipedia.org/wiki/List_of_tz_database_time_zones

Need to check if we even provide them, they are only in the legacy timezone db.

@emoral435 emoral435 assigned emoral435 and unassigned susnux Jan 23, 2024
@emoral435
Copy link
Contributor

Editing the title of the issue to be more descriptive and moving some of the descriptions to the description section

@emoral435 emoral435 changed the title [BITV] 9.1.4.1/8.1 - The selected/activated elements of the time zone combobox are visually marked by a light gray background (1,1:1 to white) and remain below the contrast ratio of 3:1 that is needed to indicate the state visually. (1) [BITV] 9.1.4.1/8.1 - NcTimezonePicker group headings / continents groupings do not meet contrast ratio (1.1:1 instead of the 3:1 contrast ratio that is required) Jan 23, 2024
@emoral435 emoral435 added this to the Nextcloud 29 milestone Jan 23, 2024
@emoral435
Copy link
Contributor

@susnux

My idea was to either have two boxes or to allow to select regions for filtering. E.g. Europe and then you can select the zone e.g. Berlin within the same box.
While still allowing to select Europe/Berlin directly.

I agree, I think potentially having seperate selection pickers would make this better, but due to the time constraints that we have right now, I'll contact the design team to see what solution we can come up with. Either a selection filter, or just changing the headings color to meet the 3:1 ratio, or some other solution that they want is what will work for us to get the certification ! Will update here once I receive a reply

@susnux
Copy link
Contributor

susnux commented Jan 23, 2024

@emoral435 simply removing the grouping is enough for the moment, meaning remove the headers should work for the moment :)

@emoral435
Copy link
Contributor

@susnux Gotcha, will move forward with that choice then! Thank you :) 🚀

@emoral435 emoral435 added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jan 24, 2024
@emoral435
Copy link
Contributor

dependency update happening in the library that affects this issue in nextcloud-libraries/nextcloud-vue#5130

@emoral435 emoral435 added 4. to release Ready to be released and/or waiting for tests to finish pending dependency update and removed 3. to review Waiting for reviews labels Jan 25, 2024
@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Feb 2, 2024

@emoral435 please check in which NcVue version is your PR available. If it is not yet released then this Issue should be in Parked, not in Done

@emoral435
Copy link
Contributor

Ah - I got confused on which NcVue version this PR was in, I thought it was for 8.4.0! This one is ready for the a11y28check once #43064 gets merged!

@szaimen szaimen closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility enhancement
Projects
None yet
Development

No branches or pull requests

4 participants