-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BITV] 9.1.4.1/8.1 - NcTimezonePicker group headings / continents groupings do not meet contrast ratio (1.1:1 instead of the 3:1 contrast ratio that is required) #41842
Comments
This is not the active element but a "heading" to group the timezones by continents. |
Asked designers but would prefer to remove all groups because it has only a decorative "function" |
From design channel: we could also flatten the structure to Europe/Berlin and remove all groups. |
My idea was to either have two boxes or to allow to select regions for filtering. E.g. |
Need to check if we even provide them, they are only in the legacy timezone db. |
Editing the title of the issue to be more descriptive and moving some of the descriptions to the description section |
I agree, I think potentially having seperate selection pickers would make this better, but due to the time constraints that we have right now, I'll contact the design team to see what solution we can come up with. Either a selection filter, or just changing the headings color to meet the 3:1 ratio, or some other solution that they want is what will work for us to get the certification ! Will update here once I receive a reply |
@emoral435 simply removing the grouping is enough for the moment, meaning remove the headers should work for the moment :) |
@susnux Gotcha, will move forward with that choice then! Thank you :) 🚀 |
dependency update happening in the library that affects this issue in nextcloud-libraries/nextcloud-vue#5130 |
@emoral435 please check in which NcVue version is your PR available. If it is not yet released then this Issue should be in Parked, not in Done |
Ah - I got confused on which NcVue version this PR was in, I thought it was for 8.4.0! This one is ready for the a11y28check once #43064 gets merged! |
https://report.bitvtest.de/default-en/cbedb5ef-4815-4cba-a83d-995599c178c3.html#checkpoint-45ae33ca9f-v8-n1
The headers / Continent of the grouped areas in the NcTimezonePicker are visually marked by a light gray background (1,1:1 to white) and remain below the contrast ratio of 3:1 that is needed to indicate the state visually.
The text was updated successfully, but these errors were encountered: