Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV] 9.4.1.2/3.4 - The "Details" section contains a favorite button, where the status is only communicated to screen reader users in the "on" state using the aria-pressed="true" attribute. (2) #41892

Closed
JuliaKirschenheuter opened this issue Nov 29, 2023 · 5 comments
Labels

Comments

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Nov 29, 2023

The "aria-pressed" attribute should be used in both states.

https://report.bitvtest.de/default-en/cbedb5ef-4815-4cba-a83d-995599c178c3.html#checkpoint-bfbf07e5c3-v3-n4

9.4.1.2/11.4 - https://report.bitvtest.de/default-en/cbedb5ef-4815-4cba-a83d-995599c178c3.html#checkpoint-bfbf07e5c3-v11-n4

@JuliaKirschenheuter JuliaKirschenheuter added 1. to develop Accepted and waiting to be taken care of accessibility labels Nov 29, 2023
@JuliaKirschenheuter JuliaKirschenheuter changed the title [BITV] 9.4.1.2/3.4 - The "Details" section contains a favorite button, where the status is only communicated to screen reader users in the "on" state using the aria-pressed="true" attribute. The "aria-pressed" attribute should be used in both states. (2) [BITV] 9.4.1.2/3.4 - The "Details" section contains a favorite button, where the status is only communicated to screen reader users in the "on" state using the aria-pressed="true" attribute. (2) Nov 29, 2023
@susnux
Copy link
Contributor

susnux commented Nov 30, 2023

probably already fixed with #41450 or #41481

@emoral435 emoral435 self-assigned this Dec 1, 2023
@emoral435 emoral435 added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Dec 1, 2023
@emoral435
Copy link
Contributor

this seems relatively easy to change if its not fixed with either of those pr's, but ill check it when I am home currently at university so just going to assign myself to this issue to either code / close this when I get home)

@giantmolecules1
Copy link

Nice

@emoral435
Copy link
Contributor

emoral435 commented Dec 9, 2023

After doing some investigating, it seems like this button does not have any aria-pressed labelled associated to it (correct me if I am wrong!), so it will need to be added to the actual button itself alongside its own toggle functionality, though the issue lies within the component in the nextcloud-vue repository

@JuliaKirschenheuter
Copy link
Contributor Author

This issue can be closed because not relevant anymore after #41481. In other places it is just a button and no improvements have to be done.

@ShGKme ShGKme closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants