Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: versions 30.0.2 to 31.0.0 and earlier do not send an email notification when a file is uploaded or deleted, only if renamed #49133

Open
5 of 8 tasks
tigernero79 opened this issue Nov 7, 2024 · 64 comments · Fixed by #49688
Assignees
Milestone

Comments

@tigernero79
Copy link

⚠️ This issue respects the following points: ⚠️

Bug description

Hello developers.

After updating to version 30.0.2, file sharing via email doesn't work as it should, I think. No email is sent to the sharer unless you rename the file.

So, the person I try to share files with doesn't get notifications except when the file is renamed. Nothing in the logs.

Typically, email works.

Steps to reproduce

  1. upload files to a folder with active notifications
  2. wait for an email notification of successful upload to be sent
    3.no notification email is sent to the recipient
  3. however, if you modify the already existing file, the recipient receives notification of the renaming

Expected behavior

I expect that when I upload a file I will be notified via email

Nextcloud Server version

30

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.3

Web server

Apache (supported)

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@tigernero79 tigernero79 added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Nov 7, 2024
@tigernero79 tigernero79 changed the title [Bug]: 30.0.2 and lower versions do not email when a file is uploaded or deleted but only if renamed [Bug]: versions 30.0.2 and earlier do not send an email notification when a file is uploaded or deleted, only if renamed Nov 7, 2024
@tigernero79
Copy link
Author

#48012 (comment)

@rx80

This comment has been minimized.

@tigernero79

This comment has been minimized.

@martink1979

This comment has been minimized.

@tigernero79

This comment has been minimized.

@RDequal

This comment has been minimized.

@5pr1nz

This comment has been minimized.

@dom6770

This comment has been minimized.

@tigernero79

This comment has been minimized.

@jfriedrichs85

This comment has been minimized.

@skjnldsv skjnldsv added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Dec 6, 2024
@skjnldsv skjnldsv self-assigned this Dec 6, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Dec 6, 2024

Alright folks, sorry for the trouble and thanks for pinging again.
We're a bit overwhelmed here 🫠

Just to clarify, we're talking about this, correct? (don't respond, use reactions pls 👍 👎 )

  1. Create a mail share to someone
  2. That someone does receive a mail notification
  3. Have that someone send files to the folder you share
  4. You don't get notifications as you should 😢

@dom6770
Copy link

dom6770 commented Dec 6, 2024

We could observe this bug on any shared folder, regardless if it was shared by mail or shared to another nextcloud user.

@martink1979

This comment has been minimized.

@skjnldsv

This comment has been minimized.

@skjnldsv
Copy link
Member

skjnldsv commented Dec 6, 2024

I think I could find the issue!
I'm guessing everyone have that settings disabled?

Image

@LM-vb
Copy link

LM-vb commented Dec 6, 2024

Enabling these options solved it for me. Is this option new?

@skjnldsv
Copy link
Member

skjnldsv commented Dec 6, 2024

Since Nextcloud 30.
Mails was not enabled by default, which I guess we should.

@LM-vb
Copy link

LM-vb commented Dec 6, 2024

Neither push nor mail was enabled for me.

@skjnldsv
Copy link
Member

skjnldsv commented Dec 6, 2024

Fix in #49688

@LaSepp
Copy link

LaSepp commented Dec 17, 2024

We're facing the same issue.

To be clear: I don't know if it would work on a shared link or email with the mentioned option, but we are not doing this.
We share the folder to other users on the same nextcloud instance.

Uploads and deletes show up in the activity app but not in the notification mail.
Renames and moves do show up in both the activity app and the notificatition mail.

@hosse
Copy link

hosse commented Dec 20, 2024

We have had this problem since version 30.0.0 to 30.0.4.

Since there is no solution so far, I am using the following workaround:

.../www/nextcloud/lib/private/Share20/Share.php

#from line 590 see // and add line return true,

    public function getMailSend() {
            //changed by us
            //return $this->mailSend;
            return true;
    }

@kesselb kesselb changed the title [Bug]: versions 30.0.2 and earlier do not send an email notification when a file is uploaded or deleted, only if renamed [Bug]: no sharebyemail notification for user shares Dec 20, 2024
@kesselb kesselb added 1. to develop Accepted and waiting to be taken care of and removed 3. to review Waiting for reviews labels Dec 20, 2024
@kesselb
Copy link
Contributor

kesselb commented Dec 20, 2024

Hi everyone,

I’m sorry to hear that you’re encountering issues with the sharing functionality in Nextcloud 30. I’ve noticed that a lot of different topics are getting mixed up here, so I’d like to clarify things.

Image

I assume most of you are referring to the email mentioned above. This email is generated by a component called sharebyemail. Some of you have also shared your activity/notification configurations, but please note that those are unrelated to the issue. The emails you’re receiving when a file is modified or similar notifications are handled by the activity component.

In Nextcloud 29, this email was sent when sharing something either with external users (e.g., bob@example.org) or with users on your own Nextcloud instance.

Both cases were broken in Nextcloud 30.0.0. The issue with external shares was fixed in Nextcloud 30.0.2 with the following PR: #48381. However, the bug affecting shares with users on your instance was overlooked.

The issue is already assigned, and we’re doing our best to address the situation as soon as possible.

I hope this clears things up! Let me know if you have any further questions or need more details.

@kesselb
Copy link
Contributor

kesselb commented Dec 21, 2024

Sorry, everyone—looks like I mixed things up 🙈.

I hope my explanation about activities and share notifications was still helpful for some of you.

If you are also missing the email notification for a new share, then please give a thumbs-up to this issue: #49954.

Thanks for your patience!

@kesselb kesselb changed the title [Bug]: no sharebyemail notification for user shares [Bug]: versions 30.0.2 and earlier do not send an email notification when a file is uploaded or deleted, only if renamed Dec 21, 2024
@WuMaKu84
Copy link

Dears,
still facing this issue in 30.0.4(snap1)... actually facing it in Polls and the workaround from @hosse didn't work for me :(
any tip / hint or idea, when this issue might be solved?

@Tchuch0
Copy link

Tchuch0 commented Jan 17, 2025

Same here. Still to be fixed and its a feature that indeed i'm missing the usage

@tigernero79 tigernero79 changed the title [Bug]: versions 30.0.2 and earlier do not send an email notification when a file is uploaded or deleted, only if renamed [Bug]: versions 30.0.2 to 30.0.5 and earlier do not send an email notification when a file is uploaded or deleted, only if renamed Jan 22, 2025
@tigernero79
Copy link
Author

Guys the bug persists even in 30.0.5 when will it be fixed? Is it possible that no one notices the bug? You no longer receive email notifications when some member uploads his files to the shared folders (the email sharing problem has nothing to do with it) this is not what we are talking about here

@LM-vb
Copy link

LM-vb commented Jan 22, 2025

There is a pull request for 30.0.6: #50217
I think this addresses your issue.

@tigernero79
Copy link
Author

ok let's wait

@susnux susnux moved this to 🏗️ In progress in 📁 Files team Jan 30, 2025
@valadmindeploy
Copy link

Pb belong in oc_preferences !
Only notify_email_file_changed is set, not created, deleted, etc.

Default value are not set !

It's an urgent bug

@tigernero79
Copy link
Author

Bug bug bug 30.0.6

@tigernero79
Copy link
Author

tigernero79 commented Feb 13, 2025

unfortunately even with the release 30.0.6 the file activities in the case of upload or deletion are only displayed in the activity section but are not sent via email. only if you rename a file it happens. bug still lu after months

@skjnldsv

@joshtrichards
Copy link
Member

Wonder if this has any relation to #50627 (if it's event related)? 🤔

@tigernero79
Copy link
Author

tigernero79 commented Feb 14, 2025

I can't tell you but the thing is this: if I upload a file to a folder shared with another nextcloud user up to version 29.0.x he also had as administrator an email that listed all the uploads made or deletions and various. now only the movements or if you rename some files are notified. in the activity section there is everything but no notification is sent via email neither for uploads of files and folders nor for deletions. only for movements or renaming of files and folders. the thing is really frustrating. I also installed 31.0.0 rc4 but the bug is still there

@joshtrichards

@lchapard
Copy link

Please, It's an urgent bug ....

@sanidzinic
Copy link

Need also urgently a fix for this issue, it is an big problem because there are no email-notifications sent after uploads

@blizzz blizzz modified the milestones: Nextcloud 31, Nextcloud 32 Feb 26, 2025
@tigernero79 tigernero79 changed the title [Bug]: versions 30.0.2 to 30.0.5 and earlier do not send an email notification when a file is uploaded or deleted, only if renamed [Bug]: versions 30.0.2 to 31.0.0 and earlier do not send an email notification when a file is uploaded or deleted, only if renamed Feb 26, 2025
@tigernero79
Copy link
Author

Even with the final 31.0.0 this bug persists, is it possible to know in which release it was actually fixed? even in 31.0.0 final the notifications of uploaded or deleted files do not receive any notification via email although they appear in the activities section, only if you rename or move the file.

Can anyone tell us in which version we can expect the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗️ In progress
Development

Successfully merging a pull request may close this issue.