Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files_external always downloads whole file from locally mounted rclone fuse storage #5279

Closed
tvvid opened this issue Jun 7, 2017 · 6 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: external storage

Comments

@tvvid
Copy link

tvvid commented Jun 7, 2017

Steps to reproduce

  1. download https://rclone.org/ and mount /local_folder from any of supported cloud storage
  2. add this /local_folder, which now represents data on cloud storage, to external storage in admin page
  3. upload some few GB video mp4 file to it, and try to preview or download and stop after few seconds

Expected behaviour

when you stop in bmon should not be RX data running server should not continuously download those files when you stopped

Actual behaviour

actual behaviour is that in bmon, even after you stop previewing, disconnect your local pc from internet, vps is still downloading this file cause you have to restart php service to kill those remote connection, only after killing or restarting php RX is stopped.

Server configuration

ubuntu 16.04

Web server:
nginx

Database:
mariadb

PHP version:
php7.0-fpm

Nextcloud version: (see Nextcloud admin page)
12
Updated from an older Nextcloud/ownCloud or fresh install:
fresh
Where did you install Nextcloud from:
official website

@tvvid
Copy link
Author

tvvid commented Jun 7, 2017

And this is not vps rclone fuse or unionfs-fuse issue. nor nginx nor proxy buffering.
It is definitely files_external issue.
Because i also have installed preview plugin and enabled movie preview.
And in that case preview plugin does not try to download whole file, in bmon it takes only few bytes to generate preview and transfer stops.
But files_external transfer does not stop until it download whole few GB file.

@tvvid
Copy link
Author

tvvid commented Jun 10, 2017

its probably sabre dav fault.
It wants to read whole post data from php://input

@tvvid
Copy link
Author

tvvid commented Jun 10, 2017

i have checked inside php files.
When i changed ignore_user_abort(true) to (false) inside:
/var/www/nextcloud/apps/dav/appinfo/v1/webdav.php = NOT HELPED
/var/www/nextcloud/apps/dav/appinfo/v2/remote.php = NOT HELPED
/var/www/nextcloud/lib/private/legacy/files.php = NOT HELPED

LINE 1161 :
/var/www/nextcloud/lib/private/Files/View.php - YES - HELPED, now it works fine but is that really ok?

tvvid added a commit to tvvid/server that referenced this issue Jun 10, 2017
false to allow user to cancel download when downloading files from network storages mounted a local fuse directory
nextcloud#5279
@tvvid tvvid mentioned this issue Jun 10, 2017
@blizzz
Copy link
Member

blizzz commented Jun 12, 2017

When i changed ignore_user_abort(true) to (false) inside:

That's a contact mine, anything could happen if request are not properly handled but cancelled inbetween.

@icewind1991

@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jun 20, 2018
@ErAzOr2k
Copy link

Are there any news for this issues? I'm exactly in the same situation. I'm running fuse (rclone) as data folder. Nextcloud always loads the whole file, even when stopping download on client or stopping a video.

@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Jan 18, 2019
@skjnldsv skjnldsv added the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Aug 20, 2020
@szaimen
Copy link
Contributor

szaimen commented Jun 8, 2021

Let us track this in nextcloud/viewer#894

@szaimen szaimen closed this as completed Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: external storage
Projects
None yet
Development

No branches or pull requests

7 participants