Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing the autocomplete/autofill when adding a new user (username/password) #8392

Closed
coliff opened this issue Feb 16, 2018 · 3 comments
Closed

Comments

@coliff
Copy link
Contributor

coliff commented Feb 16, 2018

Currently when adding a new user from the web interface (/settings/users/) browser autocomplete/autofill pre-populates the username and password boxes which is quite annoying. The form, username and password inputs all have autocomplete="off" but this is ignored by most browsers (see Notes at https://caniuse.com/#search=autocomplete)

However, if the password input has autocomplete="new-password" then it prevents the form from autofilling which is a much better user experience for adding new users.

autocomplete=new-password isn't very well known but it works better than autocomplete=off.

I edited settings/templates/users/part.createuser.php to use autocomplete="new-password" on my local installation and it works great. Much easier for adding many new users.

I'd be happy to open a PR for this.

Further info:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#attr-autocomplete
https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion

@coliff
Copy link
Contributor Author

coliff commented Mar 1, 2018

I see there is a PR (#8576) for mail share password to use autocomplete=new-password from @rullzer . Would be good to add here too.

@rullzer
Copy link
Member

rullzer commented Mar 1, 2018

On current mater the password is already set to autocomplete="new-password"

@coliff
Copy link
Contributor Author

coliff commented Mar 2, 2018

Great. I see it there now (https://github.com/nextcloud/server/blob/master/settings/templates/users/part.userlist.php). Thanks - I'll close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants