Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bearer tokens are app token #12543

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Nov 20, 2018

Fixes #12498

This means that we set that it is a proper app token once it is
validated. This will allow the 2FA middleware to just run the same
check.

Fixes #12498

This means that we set that it is a proper app token once it is
validated. This will allow the 2FA middleware to just run the same
check.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Copy link
Member Author

rullzer commented Nov 20, 2018

/backport to stable14

@rullzer
Copy link
Member Author

rullzer commented Nov 20, 2018

/backport to stable13

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 20, 2018
@MorrisJobke MorrisJobke merged commit 53418f2 into master Nov 20, 2018
@MorrisJobke MorrisJobke deleted the fix/12498/bearer_tokens_are_apptokens branch November 20, 2018 10:49
@backportbot-nextcloud
Copy link

backport to stable14 in #12545

@backportbot-nextcloud
Copy link

backport to stable13 in #12546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants