-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AuthPicker: redirect oauth client to grant page #17136
Conversation
e6c258c
to
4d3dbac
Compare
Great idea! Completely agree. |
4d3dbac
to
127a1e6
Compare
@kinolaev so it is a leftover from an older time ;) |
Sorry, @rullzer, I didn't understand your position. Do you still like that the users see that message or do you want to simplify oauth login flow now? |
@kinolaev so after some thinking I'm not a huge fan of this. I'd rather make sure that we fix it for all properly. (so also for the normal flow). Let me discuss a bit with @ChristophWurst as well as he moved the login page over to a webpacked thing so maybe we can do something more fancy these days. |
Just for reference, design-wise I totally agree with @kinolaev that this needs to be simplified.
Since this is sign in and also connecting to mobile and desktop clients – thus happening a lot, I’d say we should look into this for 19? |
Yeah and witht he improved login page to vue we might now finally be able to tackle it properly. |
b47156a
to
46adb7d
Compare
Hello @rullzer, I resolved merge conflict and moved 'Please log in before granting %1$s access to your %2$s account.' and 'If you are not trying to set up a new device or app, someone is trying to trick you into granting them access to your data. In this case do not proceed and instead contact your system administrator.' messages to LoginForm. Can you review it? |
e268958
to
203f744
Compare
e293ad9
to
feee428
Compare
Signed-off-by: Sergej Nikolaev <kinolaev@gmail.com>
Signed-off-by: Sergey Nikolaev <kinolaev@gmail.com>
Signed-off-by: Sergey Nikolaev <kinolaev@gmail.com>
feee428
to
1c12f6d
Compare
Hello @rullzer, |
As there is no feedback since a while I will close this ticket. Thanks for the interest in Nextcloud and the effort put into this! 🙇 |
Hello!
This PR skips auth picker page for oauth clients.
For now nextcloud redirects user from
/apps/oauth2/authorize
to/login/flow
where user sees only login button that redirects user to/login/flow/grant
where user allows access to account. In other cases/login/flow
page is used to suggest authorization by application password but this is hidden for oauth clients, so this page is actually useless. With this PRClientFlowLogin#showAuthPickerPage
returns redirect to/login/flow/grant
instead of auth picker page andoauthState
removed from auth picker template because it will always be empty.