Mark "Talk" active on /call/token URLs #17850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
requested review from
rullzer,
Ivansss,
marcoambrosini and
danxuliu
|
Ha... PHAN is not happy here: https://drone.nextcloud.com/nextcloud/server/23079/5/6 |
nickvergessen
force-pushed
the
bugfix/noid/mark-spreed-as-active-on-call-urls
branch
from
ee0b11d to
284d218
Compare
ChristophWurst
approved these changes
Nov 8, 2019
|
Phan still not happy... |
georgehrke
reviewed
Nov 12, 2019
lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php
Outdated
Show resolved
Hide resolved
nickvergessen
force-pushed
the
bugfix/noid/mark-spreed-as-active-on-call-urls
branch
from
284d218 to
b160589
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
rullzer
force-pushed
the
bugfix/noid/mark-spreed-as-active-on-call-urls
branch
from
b160589 to
15f00f0
Compare
nickvergessen
commented
Nov 18, 2019
lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
|
Oh thanks @kesselb |
kesselb
added
4. to release
nickvergessen
deleted the
bugfix/noid/mark-spreed-as-active-on-call-urls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On backport to stable17 the class name needs to be changed, so manual backporting it is.
Steps