respect shareapi_allow_share_dialog_user_enumeration in Principal backend for Sabre/DAV #18120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgehrke
commented
Nov 26, 2019
| ); | ||
| $groupPrincipalBackend = new GroupPrincipalBackend($groupManager, $userSession, $shareManager, $l10n); | ||
| $groupPrincipalBackend = new GroupPrincipalBackend($groupManager, $userSession, $shareManager); |
There was a problem hiding this comment.
GroupPrincipalBackend doesn't even take a fourth parameter: (Also not on /stable(15|16|17)/)
https://github.com/nextcloud/server/blob/master/apps/dav/lib/DAV/GroupPrincipalBackend.php#L55
Not sure why it was there in the first place.
georgehrke
force-pushed
the
bugfix/11087/dav_principal_backend_respect_sharing_settings
branch
from
99b4447 to
9964030
Compare
|
/backport to stable17 |
|
/backport to stable16 |
tcitworld
approved these changes
Nov 29, 2019
|
Rebase ;) |
…kend for Sabre/DAV Signed-off-by: Georg Ehrke <developer@georgehrke.com>
georgehrke
force-pushed
the
bugfix/11087/dav_principal_backend_respect_sharing_settings
branch
from
9964030 to
c3748cf
Compare
|
Rebased |
skjnldsv
deleted the
bugfix/11087/dav_principal_backend_respect_sharing_settings
branch
|
The backport to stable17 failed. Please do this backport manually. |
|
GRMPF |
|
The backport to stable16 failed. Please do this backport manually. |
|
Backport to stable17: #18205 |
|
@georgehrke Do we still need a backport for 16 as well? |
|
ideally yes, let me look into it, so we can include it in the maintenance releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11087