Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend propertypath to 4000 #18126

Closed
wants to merge 1 commit into from
Closed

Conversation

J0WI
Copy link
Contributor

@J0WI J0WI commented Nov 26, 2019

Fixes #9907 and maybe also #5477

@J0WI J0WI added the 3. to review Waiting for reviews label Nov 26, 2019
@J0WI J0WI requested a review from kesselb November 26, 2019 22:59
@kesselb
Copy link
Contributor

kesselb commented Nov 27, 2019

Thanks 👍

The autoloaders are not up to date
Please run: bash build/autoloaderchecker.sh
And commit the result

server/version.php

Lines 28 to 32 in 0532f81

// We only can count up. The 4. digit is only for the internal patchlevel to trigger DB upgrades
// between betas, final and RCs. This is _not_ the public version number. Reset minor/patchlevel
// when updating major/minor version number.
$OC_Version = array(18, 0, 0, 1);

Please increase the last digit to trigger the update.

@kesselb kesselb added the bug label Nov 27, 2019
@kesselb kesselb added this to the Nextcloud 18 milestone Nov 27, 2019
This was referenced Dec 11, 2019
Co-authored-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
@georgehrke
Copy link
Member

Especially if you heavily use calendar and contacts, there will be many entries in oc_properties.
I'm worried this Migration will die in a timeout

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@J0WI
Copy link
Contributor Author

J0WI commented Dec 16, 2019

Is there a way to solve this?

@ChristophWurst
Copy link
Member

Discussed this with @rullzer briefly.

  • We shouldn't do this migration by default as it will most likely time out on mid-sized to large installations.
  • For 19 we can change the original migration so new installations get a more appropriate column width by default
  • Add an optional repair step like we have for missing indices, so admins can later migrate the column with with an occ command

I'll also put that into the ticket and close the PR as we won't integrate it in its current form.

@ChristophWurst ChristophWurst removed this from the Nextcloud 18 milestone Dec 19, 2019
@J0WI J0WI deleted the propertypath4k branch December 19, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error reporting for too long filepaths (>255 chars)
4 participants