Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tooltips to display name and email #18193

Merged
merged 1 commit into from
Dec 20, 2019
Merged

Add tooltips to display name and email #18193

merged 1 commit into from
Dec 20, 2019

Conversation

onehappycat
Copy link
Member

@onehappycat onehappycat commented Dec 2, 2019 •
edited
Loading

#18158 Add tooltips to username 'display name' and 'email' fields in user management.

@onehappycat onehappycat force-pushed the user_management_tooltips branch from 45b835d to 24ca943 Compare December 2, 2019 17:45
@kesselb
Copy link
Contributor

kesselb commented Dec 2, 2019

Thanks 👍

Would you mind to share a screenshot? ;)

@kesselb kesselb requested a review from skjnldsv December 2, 2019 18:20
@kesselb kesselb added this to the Nextcloud 18 milestone Dec 2, 2019
@kesselb kesselb added 3. to review Waiting for reviews enhancement labels Dec 2, 2019
@onehappycat
Copy link
Member Author

Thanks 👍

Would you mind to share a screenshot? ;)

Screenshot 2019-12-02 at 19 45 08

@onehappycat onehappycat changed the title Add tooltips to username and email Add tooltips to display name and email Dec 2, 2019
@jancborchardt jancborchardt requested a review from GretaD December 3, 2019 05:13
skjnldsv
skjnldsv requested changes Dec 3, 2019
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, this will conflict with @GretaD's work on the new layout #17239
I would rather have this wait until the other to ease the potential rebase :)

@GretaD
Copy link
Contributor

GretaD commented Dec 3, 2019 •
edited
Loading

yes please lets wait, not that much left to do on my ticket. I'll ping you again.

@onehappycat
Copy link
Member Author

Sounds good. The new layout looks amazing. 👍

This was referenced Dec 11, 2019
Merged
Merged
@blizzz
Copy link
Member

blizzz commented Dec 13, 2019

@GretaD's PR was merged. What to do with this one?

@skjnldsv
Copy link
Member

rework it to add the tooltips at the correct place :)

@blizzz blizzz added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 13, 2019
@onehappycat onehappycat force-pushed the user_management_tooltips branch from 24ca943 to 033e540 Compare December 14, 2019 13:29
@onehappycat
Copy link
Member Author

Rebased to current master, added the tooltips to correct places at the new layout.

Before:
Screenshot 2019-12-14 at 14 31 28

After:
Screenshot 2019-12-14 at 14 31 36

@onehappycat onehappycat requested a review from skjnldsv December 14, 2019 13:32
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 15, 2019
skjnldsv
skjnldsv requested changes Dec 15, 2019
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments ;)

@onehappycat onehappycat force-pushed the user_management_tooltips branch from ad0805b to d97a525 Compare December 15, 2019 17:27
@onehappycat
Copy link
Member Author

onehappycat commented Dec 15, 2019 •
edited
Loading

Rebased and added the full output of make build-js-production, but webpack is still complaining.

@skjnldsv
Copy link
Member

/compile amend /

@skjnldsv
Copy link
Member

@onehappycat something else was merged, please rebase again :p
After rebase you can use the /compile amend / command to trigger a compile of any js file by our bot ;)

@onehappycat onehappycat force-pushed the user_management_tooltips branch 2 times, most recently from dd0472c to 03e240a Compare December 16, 2019 13:02
@onehappycat onehappycat requested a review from skjnldsv December 16, 2019 13:06
@skjnldsv skjnldsv force-pushed the user_management_tooltips branch from 03e240a to 02dc5fe Compare December 16, 2019 13:10
@rullzer rullzer mentioned this pull request Dec 19, 2019
Merged
18 tasks
ChristophWurst
ChristophWurst approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like happy cats

@skjnldsv skjnldsv force-pushed the user_management_tooltips branch from 02dc5fe to 7a98cee Compare December 19, 2019 13:19
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 19, 2019
@onehappycat @skjnldsv
Add tooltips to display name and email fields in Users
dab4c18 
Signed-off-by: onehappycat <onehappycat@gmx.com>
@skjnldsv skjnldsv force-pushed the user_management_tooltips branch from 7a98cee to dab4c18 Compare December 19, 2019 15:26
@skjnldsv skjnldsv merged commit 4bec80e into nextcloud:master Dec 20, 2019
@welcome
Copy link

welcome bot commented Dec 20, 2019

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@GretaD GretaD Awaiting requested review from GretaD

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
None yet
Milestone
Nextcloud 18.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@onehappycat @kesselb @GretaD @blizzz @skjnldsv @ChristophWurst