Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup old log and fix share icon sidebar opening in breadcrumbs #18425

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Cleanup old log and fix share icon sidebar opening in breadcrumbs #18425

merged 1 commit into from
Dec 16, 2019

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 16, 2019 •
edited by gary-kim
Loading

@skjnldsv
Cleanup old log and fix share icon sidebar opening in breadcrumbs
f8a3663 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug 3. to review Waiting for reviews feature: sharing regression feature: file sidebar Related to the file sidebar component labels Dec 16, 2019
@skjnldsv skjnldsv added this to the Nextcloud 18 milestone Dec 16, 2019
@skjnldsv skjnldsv self-assigned this Dec 16, 2019
@skjnldsv skjnldsv mentioned this pull request Dec 16, 2019
Closed
14 tasks
rullzer
rullzer approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 16, 2019
@skjnldsv skjnldsv merged commit 29f6f15 into master Dec 16, 2019
@skjnldsv skjnldsv deleted the fix/breadcrumbs branch December 16, 2019 13:07
juliusknorr pushed a commit that referenced this pull request Dec 16, 2019
@skjnldsv @juliusknorr
Cleanup old log and fix share icon sidebar opening in breadcru… (#18425)
e54faa1 
Cleanup old log and fix share icon sidebar opening in breadcrumbs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@wiswedel wiswedel Awaiting requested review from wiswedel

@kesselb kesselb Awaiting requested review from kesselb

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: file sidebar Related to the file sidebar component feature: sharing regression
Projects
None yet
Milestone
Nextcloud 18.0.0
Development

Successfully merging this pull request may close these issues.

Nextcloud 18b2: can't click share icon in folder
3 participants
@skjnldsv @rullzer @juliusknorr