Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sidebar enabled check #18449

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Fix Sidebar enabled check #18449

merged 1 commit into from
Dec 19, 2019

Conversation

skjnldsv
Copy link
Member

The Tab constructor was expected to have an enabled function.

@skjnldsv skjnldsv added bug 3. to review Waiting for reviews feature: file sidebar Related to the file sidebar component labels Dec 17, 2019
@skjnldsv skjnldsv added this to the Nextcloud 18 milestone Dec 17, 2019
@skjnldsv skjnldsv self-assigned this Dec 17, 2019
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure... 🐘

apps/files/js/filelist.js Outdated Show resolved Hide resolved
apps/files/src/models/Tab.js Outdated Show resolved Hide resolved
apps/files/src/views/Sidebar.vue Outdated Show resolved Hide resolved
@skjnldsv skjnldsv force-pushed the fix/sidebar/enabled-check branch from 253e569 to 7712a66 Compare December 19, 2019 07:49
@skjnldsv
Copy link
Member Author

/compile amend /

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the fix/sidebar/enabled-check branch from 7712a66 to 27dc4ef Compare December 19, 2019 07:51
@rullzer rullzer mentioned this pull request Dec 19, 2019
34 tasks
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skjnldsv I tested this but it still doesn't work for me... Are you able to disable tabs?

@skjnldsv
Copy link
Member Author

@skjnldsv I tested this but it still doesn't work for me... Are you able to disable tabs?

yes, works for me, let's call

@rullzer rullzer mentioned this pull request Dec 19, 2019
18 tasks
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, thanks :)

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 19, 2019
@skjnldsv skjnldsv merged commit 79b9be7 into master Dec 19, 2019
@skjnldsv skjnldsv deleted the fix/sidebar/enabled-check branch December 19, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: file sidebar Related to the file sidebar component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants