Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also center vertically when cropping previews #18536

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Also center vertically when cropping previews #18536

merged 1 commit into from
Dec 23, 2019

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 22, 2019 •
edited
Loading

Before After
Capture d’écran_2019-12-22_15-09-09 Capture d’écran_2019-12-22_15-09-19

@skjnldsv
Also center vertically when cropping previews
6df44e4 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added this to the Nextcloud 18 milestone Dec 22, 2019
@skjnldsv skjnldsv requested a review from rullzer December 22, 2019 14:08
rullzer
rullzer approved these changes Dec 23, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

gary-kim
gary-kim approved these changes Dec 23, 2019
View reviewed changes
Copy link
Member

@gary-kim gary-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@rullzer rullzer merged commit 323fe46 into master Dec 23, 2019
@rullzer rullzer deleted the enhancement/preview-center-vertically branch December 23, 2019 07:36
@gary-kim gary-kim added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress 3. to review Waiting for reviews labels Dec 23, 2019
@gary-kim
Copy link
Member

gary-kim commented Dec 23, 2019 •
edited
Loading

Wow, amazing speed!

@rullzer rullzer mentioned this pull request Dec 23, 2019
Merged
18 tasks
@skjnldsv skjnldsv mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gary-kim gary-kim gary-kim approved these changes

@rullzer rullzer rullzer approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: previews and thumbnails
Projects
None yet
Milestone
Nextcloud 18.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @gary-kim @rullzer