Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in occ #18641

Merged
merged 2 commits into from
Jan 5, 2020
Merged

Fix typo in occ #18641

merged 2 commits into from
Jan 5, 2020

Conversation

HarHarLinks
Copy link
Contributor

Signed-off-by: Kim Brose kim.brose@rwth-aachen.de

Signed-off-by: Kim Brose <kim.brose@rwth-aachen.de>
@gary-kim gary-kim added 3. to review Waiting for reviews bug labels Jan 3, 2020
@gary-kim gary-kim added this to the Nextcloud 18 milestone Jan 3, 2020
@gary-kim gary-kim requested a review from rullzer January 3, 2020 05:10
@gary-kim
Copy link
Member

gary-kim commented Jan 3, 2020

Thank you for your contribution!

@gary-kim gary-kim added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 3, 2020
@rullzer
Copy link
Member

rullzer commented Jan 3, 2020

Ah CI fails. Could you fix the tests as well?

@gary-kim
Copy link
Member

gary-kim commented Jan 3, 2020

This should do the trick

diff --git a/tests/Core/Command/User/SettingTest.php b/tests/Core/Command/User/SettingTest.php
index 7d71734334..8486e7fc3c 100644
--- a/tests/Core/Command/User/SettingTest.php
+++ b/tests/Core/Command/User/SettingTest.php
@@ -93,7 +93,7 @@ class SettingTest extends TestCase {
 				[['ignore-missing-user', false]],
 				[],
 				null,
-				'The user "username" does not exists.',
+				'The user "username" does not exist.',
 			],
 
 			[

@gary-kim gary-kim added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Jan 3, 2020
Signed-off-by: Kim Brose <kim.brose@rwth-aachen.de>
@HarHarLinks
Copy link
Contributor Author

@gary-kim that's about what I suspected, thanks for already finding it.
Let's hope this build succeeds.

@gary-kim gary-kim added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Jan 4, 2020
@rullzer rullzer merged commit d7fdab0 into nextcloud:master Jan 5, 2020
@welcome
Copy link

welcome bot commented Jan 5, 2020

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@rullzer
Copy link
Member

rullzer commented Jan 5, 2020

It did!

Welcome to the club @HarHarLinks

@HarHarLinks HarHarLinks deleted the patch-1 branch January 6, 2020 00:18
@rullzer rullzer mentioned this pull request Jan 6, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants