Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ID3Parser to v1.1.0 for php7.4 compat #18710

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Update ID3Parser to v1.1.0 for php7.4 compat #18710

merged 1 commit into from
Jan 7, 2020

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jan 7, 2020 •
edited
Loading

@ChristophWurst ChristophWurst added the 2. developing Work in progress label Jan 7, 2020
@ChristophWurst ChristophWurst self-assigned this Jan 7, 2020
@rullzer
Copy link
Member

rullzer commented Jan 7, 2020

Please rebase and undraft ;)

@ChristophWurst
Update ID3Parser to v1.1.0 for php7.4 compat
3d53e62 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the dependachristoph/composer/id3parser-0.1.1 branch from 09d477e to 3d53e62 Compare January 7, 2020 15:03
@ChristophWurst ChristophWurst marked this pull request as ready for review January 7, 2020 15:03
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 7, 2020
@rullzer rullzer merged commit 782901e into master Jan 7, 2020
@rullzer rullzer deleted the dependachristoph/composer/id3parser-0.1.1 branch January 7, 2020 18:27
@rullzer rullzer mentioned this pull request Jan 8, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@rullzer rullzer rullzer approved these changes

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @rullzer @kesselb