Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not include mountpoints when calculating quota usage on WebDAV #19436

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Do not include mountpoints when calculating quota usage on WebDAV #19436

merged 1 commit into from
Apr 30, 2020

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Feb 12, 2020 •
edited
Loading

Otherwise the quota calculation shown in the desktop client differs from how we calculate quota and show it in the web interface.

cc @misch7 as discussed

@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Feb 12, 2020
@juliusknorr juliusknorr added this to the Nextcloud 19 milestone Feb 12, 2020
rullzer
rullzer approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sure. Altough I guess we'll get back complains at some point.
But yes it should be consistent.

@rullzer
Copy link
Member

rullzer commented Feb 12, 2020

CI fails

@rullzer rullzer force-pushed the bugfix/noid/dav-quota-calculation branch from 731b7dd to f308f44 Compare March 24, 2020 20:42
@rullzer
Copy link
Member

rullzer commented Apr 2, 2020

CI fails

ping

This was referenced Apr 4, 2020
Merged
Merged
This was referenced Apr 15, 2020
Merged
Merged
@rullzer rullzer mentioned this pull request Apr 23, 2020
Merged
11 tasks
@juliusknorr juliusknorr force-pushed the bugfix/noid/dav-quota-calculation branch from f308f44 to 7f1b55c Compare April 24, 2020 15:03
@juliusknorr
Copy link
Member Author

Let's see what CI says about that.

@juliusknorr
Do not include mountpoints when calculating quota usage on WebDAV
902d125 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/noid/dav-quota-calculation branch from 7f1b55c to 902d125 Compare April 24, 2020 16:15
@rullzer rullzer merged commit b8b53a2 into master Apr 30, 2020
@rullzer rullzer deleted the bugfix/noid/dav-quota-calculation branch April 30, 2020 07:13
@icewind1991 icewind1991 mentioned this pull request Mar 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusknorr @rullzer @icewind1991