-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Already enabled apps #19514
Merged
Merged
Already enabled apps #19514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sndrr
force-pushed
the
already-enabled-apps
branch
from
February 17, 2020 09:18
2ddaa70
to
45ad021
Compare
sndrr
force-pushed
the
already-enabled-apps
branch
from
February 17, 2020 10:10
45ad021
to
44cb861
Compare
kesselb
approved these changes
Feb 21, 2020
Signed-off-by: Sander Ruitenbeek <s.ruitenbeek@getgoing.nl>
Signed-off-by: Sander Ruitenbeek <s.ruitenbeek@getgoing.nl> Signed-off-by: Sander Ruitenbeek <s.ruitenbeek@getgoing.nl>
ChristophWurst
approved these changes
Apr 24, 2020
ChristophWurst
force-pushed
the
already-enabled-apps
branch
from
April 24, 2020 14:33
44cb861
to
6b62bef
Compare
rebased |
ChristophWurst
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Apr 24, 2020
georgehrke
approved these changes
Apr 24, 2020
nodiscc
added a commit
to nodiscc/xsrv
that referenced
this pull request
Jun 1, 2020
nodiscc
added a commit
to nodiscc/xsrv
that referenced
this pull request
Jul 5, 2020
- determine appropriate setup procedure depending on whether nextcloud is already installed or not, installed version and current role version - use ansible local fact file to store nextcloud installed version - use temporary extraction directory and replace the old copy with the new one instead of unpacking directly into the documentroot - installation is now idempotent - ensure correct/restrictive permissions are set - nextcloud: move apache configuration steps to separate file, add automatic virtualhost configuration for nextcloud, group previous CSP settings in vhost configuration file - reorder setup procedure (setup apache last) - enable additional php modules https://docs.nextcloud.com/server/16/admin_manual/installation/source_installation.html#apache-web-server-configuration - Note: 'become' is not a valid attribute for a TaskInclude, use include - https://docs.ansible.com/ansible/latest/modules/include_module.html - reload apache instead of restarting when possible - fix Module did not set no_log for update_password (mysql_user) - update documentation, add screenshots - use ansible-vault to manage secret variables by default - templatize nextcloud domain name/install directory/full URL - make app enable/disable task idempotent - nextcloud/server#19514, nextcloud/server#17789 - require manual configuration of nextcloud FQDN - update calendar app to 2.0.2 - https://docs.nextcloud.com/server/16/admin_manual/maintenance/manual_upgrade.html
nodiscc
added a commit
to nodiscc/xsrv
that referenced
this pull request
Jul 14, 2020
- determine appropriate setup procedure depending on whether nextcloud is already installed or not, installed version and current role version - use ansible local fact file to store nextcloud installed version - use temporary extraction directory and replace the old copy with the new one instead of unpacking directly into the documentroot - installation is now idempotent - ensure correct/restrictive permissions are set - nextcloud: move apache configuration steps to separate file, add automatic virtualhost configuration for nextcloud, group previous CSP settings in vhost configuration file - reorder setup procedure (setup apache last) - enable additional php modules https://docs.nextcloud.com/server/16/admin_manual/installation/source_installation.html#apache-web-server-configuration - Note: 'become' is not a valid attribute for a TaskInclude, use include - https://docs.ansible.com/ansible/latest/modules/include_module.html - reload apache instead of restarting when possible - fix Module did not set no_log for update_password (mysql_user) - update documentation, add screenshots - use ansible-vault to manage secret variables by default - templatize nextcloud domain name/install directory/full URL - make app enable/disable task idempotent - nextcloud/server#19514, nextcloud/server#17789 - require manual configuration of nextcloud FQDN - update calendar app to 2.0.2 - https://docs.nextcloud.com/server/16/admin_manual/maintenance/manual_upgrade.html
nodiscc
added a commit
to nodiscc/xsrv
that referenced
this pull request
Jul 14, 2020
- determine appropriate setup procedure depending on whether nextcloud is already installed or not, installed version and current role version - use ansible local fact file to store nextcloud installed version - use temporary extraction directory and replace the old copy with the new one instead of unpacking directly into the documentroot - installation is now idempotent - ensure correct/restrictive permissions are set - nextcloud: move apache configuration steps to separate file, add automatic virtualhost configuration for nextcloud, group previous CSP settings in vhost configuration file - reorder setup procedure (setup apache last) - enable additional php modules https://docs.nextcloud.com/server/16/admin_manual/installation/source_installation.html#apache-web-server-configuration - Note: 'become' is not a valid attribute for a TaskInclude, use include - https://docs.ansible.com/ansible/latest/modules/include_module.html - reload apache instead of restarting when possible - fix Module did not set no_log for update_password (mysql_user) - update documentation, add screenshots - use ansible-vault to manage secret variables by default - templatize nextcloud domain name/install directory/full URL - make app enable/disable task idempotent - nextcloud/server#19514, nextcloud/server#17789 - require manual configuration of nextcloud FQDN - update calendar app to 2.0.2 - https://docs.nextcloud.com/server/16/admin_manual/maintenance/manual_upgrade.html
nodiscc
added a commit
to nodiscc/xsrv
that referenced
this pull request
Jul 14, 2020
- determine appropriate setup procedure depending on whether nextcloud is already installed or not, installed version and current role version - use ansible local fact file to store nextcloud installed version - use temporary extraction directory and replace the old copy with the new one instead of unpacking directly into the documentroot - installation is now idempotent - ensure correct/restrictive permissions are set - nextcloud: move apache configuration steps to separate file, add automatic virtualhost configuration for nextcloud, group previous CSP settings in vhost configuration file - reorder setup procedure (setup apache last) - enable additional php modules https://docs.nextcloud.com/server/16/admin_manual/installation/source_installation.html#apache-web-server-configuration - Note: 'become' is not a valid attribute for a TaskInclude, use include - https://docs.ansible.com/ansible/latest/modules/include_module.html - reload apache instead of restarting when possible - fix Module did not set no_log for update_password (mysql_user) - update documentation, add screenshots - use ansible-vault to manage secret variables by default - templatize nextcloud domain name/install directory/full URL - make app enable/disable task idempotent - nextcloud/server#19514, nextcloud/server#17789 - require manual configuration of nextcloud FQDN - update calendar app to 2.0.2 - https://docs.nextcloud.com/server/16/admin_manual/maintenance/manual_upgrade.html - update doc - add php-mysql requirement - update role metadata, depends on lamp role - upgrade nextcloud to 19.0.0, upgrade all nextcloud apps - add fine-grained ansible tags - upgrade: copy config.php from the old installation to the new, fix permissions - apache: integration Unset system-wide Content-Security-Policy header since Nextcloud provides its own CSP - add nextcloud_https_mode config variable (selfsigned/letsencrypt/none) - add tasks to generate self-signed certificates - automatically install applications using occ app:install command, remove app-related variables and ansible tasks - upgrade all applications during setup - enable APCu memcache https://docs.nextcloud.com/server/19/admin_manual/configuration_server/caching_configuration.html - gallery app replaced with photos app - update doc - fix upgrade mechanism/only copy old config.pho when nextcloud_action == 'upgrade' - remove old installation directory at the end of upgrades note on upgrades: 'Exception: Updates between multiple major versions and downgrades are unsupported.' note on config.php file ownership/permissions: occ has to be executed with the user that owns the file config/config.php either www-data must OWN config.php (rw group access is not enough), or we have to run occ as root - the first option is probably closer to least-privilege principle note on data directory permissions: Your data directory is readable by other users Please change the permissions to 0770 so that the directory cannot be listed by other users. An unhandled exception has been thrown: Exception: Environment not properly prepared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17789.