Various user settings fixes #19533
Merged
Various user settings fixes #19533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
added
bug
3. to review
juliusknorr
requested review from
ChristophWurst,
kesselb,
GretaD,
skjnldsv and
gary-kim
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/noid/user-settings
branch
from
e05389c to
4e77df7
Compare
GretaD
approved these changes
Feb 19, 2020
ChristophWurst
approved these changes
Feb 21, 2020
|
Great set of fixes. Can we backport them to 18? |
I think these are for 18. |
Yes, definitely.
The master branch is already heading towards Nextcloud 19. Fixes for upcoming 18 releases need to be backported to the stable18 branch. |
|
/backport to stable18 |
|
The backport to stable18 failed. Please do this backport manually. |
|
The row is very high with a few users ;) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19503
Fixes #18920
Fixes #18560
Fixes #19513
The grid view is still a pain to get properly here, but i think most urgent issues should be fixed by that PR.