Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with Keystone auth v3 in files_external app #19540

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

jlutran
Copy link
Contributor

@jlutran jlutran commented Feb 19, 2020

This PR fixes some issues with Keystone auth v3 in files_external app :

  • Keystone auth v3 requires a scoped authorization payload (already fixed for primary storage in ba71918.
  • Tenant (project) name parameter was missing.
  • Region parameter is mandatory, because of this check.

Fixes #5882
Fixes #11264

@gary-kim gary-kim added 3. to review Waiting for reviews bug labels Feb 19, 2020
@gary-kim gary-kim added this to the Nextcloud 19 milestone Feb 19, 2020
@gary-kim gary-kim requested review from icewind1991, MorrisJobke, rullzer, nickvergessen and babelouest and removed request for babelouest February 19, 2020 11:20
@alejandroscf
Copy link

I've just tested in Nextcloud 17.0.3 and this works.

As you may already know OVH is turning off auth v2 for their swift storage next month, so probably many nextcloud admins will need this change to work also in Nextcloud 17 and 18 soon. It would be great if this change could be included in the next releases of 17 and 18, maybe that's whats going to happen anyway as I'm not familiar with the release process.

@babolivier
Copy link

Any news about support for this in Nextcloud 17 and 18?

@rlamarche
Copy link

Well done, working for me too. The strange thing is that I made it working even without applying this pull request to my nextcloud, just by updating the current configuration and putting "Default" in domain, and no tenant name in any visible fields.
By the way I prefer to apply this patch to be sure.

This was referenced Apr 4, 2020
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Signed-off-by: Julien Lutran <julien.lutran@corp.ovh.com>
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 15, 2020
@MorrisJobke
Copy link
Member

Unrelated CS failures:

Loaded config default from "/home/runner/work/server/server/.php_cs.dist".
6
   1) lib/private/Files/Stream/HashWrapper.php
7
   2) tests/lib/Files/Stream/HashWrapperTest.php

I will submit them in a separate PR.

@MorrisJobke MorrisJobke merged commit d8557d0 into nextcloud:master Apr 15, 2020
@welcome
Copy link

welcome bot commented Apr 15, 2020

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@hregis
Copy link

hregis commented May 15, 2020

Hello
it's possible to include this fixes in the next release of 18.x version please ?
Thanks

@icewind1991
Copy link
Member

/backport to stable18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
9 participants