-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with Keystone auth v3 in files_external app #19540
Conversation
I've just tested in Nextcloud 17.0.3 and this works. As you may already know OVH is turning off auth v2 for their swift storage next month, so probably many nextcloud admins will need this change to work also in Nextcloud 17 and 18 soon. It would be great if this change could be included in the next releases of 17 and 18, maybe that's whats going to happen anyway as I'm not familiar with the release process. |
Any news about support for this in Nextcloud 17 and 18? |
Well done, working for me too. The strange thing is that I made it working even without applying this pull request to my nextcloud, just by updating the current configuration and putting "Default" in domain, and no tenant name in any visible fields. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
Signed-off-by: Julien Lutran <julien.lutran@corp.ovh.com>
f41fb19
to
3e849da
Compare
Unrelated CS failures:
I will submit them in a separate PR. |
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Hello |
/backport to stable18 |
This PR fixes some issues with Keystone auth v3 in files_external app :
Fixes #5882
Fixes #11264