Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close the streams in writeStream even when there is an exception #20361

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Close the streams in writeStream even when there is an exception #20361

merged 1 commit into from
Apr 15, 2020

Conversation

icewind1991
Copy link
Member

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991
Close the streams in writeStream even when there is an exception
ccbf305 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Apr 8, 2020
@icewind1991 icewind1991 added this to the Nextcloud 19 milestone Apr 8, 2020
@icewind1991
Copy link
Member Author

/backport to stable18

@icewind1991
Copy link
Member Author

/backport to stable17

@icewind1991 icewind1991 mentioned this pull request Apr 8, 2020
Merged
rullzer
rullzer approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sane

This was referenced Apr 9, 2020
Merged
Merged
@ChristophWurst ChristophWurst merged commit 3013271 into master Apr 15, 2020
@ChristophWurst ChristophWurst deleted the write-stream-close-on-exception branch April 15, 2020 08:48
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 15, 2020
Merged
@backportbot-nextcloud
Copy link

backport to stable18 in #20493

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 15, 2020
Merged
@backportbot-nextcloud
Copy link

backport to stable17 in #20494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer rullzer approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.
3 participants
@icewind1991 @rullzer @ChristophWurst