Allow to edit admin user #20381
Merged
Allow to edit admin user #20381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
approved these changes
Apr 10, 2020
|
/backport to stable18 |
gary-kim
approved these changes
Apr 13, 2020
|
/compile amend / |
npmbuildbot-nextcloud
bot
force-pushed
the
fix/allow_edit_admin_user
branch
from
16aa0e8 to
521bb8a
Compare
|
Somehow, that made things worse. Whoops |
kesselb
force-pushed
the
fix/allow_edit_admin_user
branch
2 times, most recently
from
250bd5d to
b7d6edb
Compare
Fixed that for you. |
kesselb
reviewed
Apr 13, 2020
|
tests not happy |
kesselb
force-pushed
the
fix/allow_edit_admin_user
branch
from
b7d6edb to
74f899b
Compare
master is failing with the same error 🎉 |
will check asap to fix the test, but if someone wants to take over, i will be same happy :) |
kesselb
force-pushed
the
fix/allow_edit_admin_user
branch
from
74f899b to
262c051
Compare
|
Rebased the branch. |
kesselb
force-pushed
the
fix/allow_edit_admin_user
branch
from
262c051 to
cdf807f
Compare
kesselb
force-pushed
the
fix/allow_edit_admin_user
branch
2 times, most recently
from
0f35ca5 to
268d406
Compare
Signed-off-by: GretaD <gretadoci@gmail.com> Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
fix/allow_edit_admin_user
branch
from
268d406 to
d17c58e
Compare
|
wait, since the test is broken on master, we can merge this for now and fix test in another time? |
|
Yes. The failing tests are unrelated to this change. |
GretaD
added
4. to release
Taking this as granted, I will merge it :P |
|
The backport to stable18 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like after rebase of #18818 there were some reverted lines. This pr fixes that.
ref #18818 (review)
fixes #18530