[stable18] Ensured large image is unloaded from memory when generating previews

[backportbot-nextcloud]

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #22008

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31610: failure

nodb

Show full log

There was 1 error:

1) Test\Preview\GeneratorTest::testGetCachedPreview
Undefined variable: maxPreviewImage

/drone/src/lib/private/Preview/Generator.php:167
/drone/src/tests/lib/Preview/GeneratorTest.php:122

--

There were 49 warnings:

1) Test\AppFramework\Controller\AuthPublicShareControllerTest::testAuthenticateAuthenticated
Trying to configure method "isAuthenticated" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\AppFramework\Http\ResponseTest::testCacheSeconds
Method getTime may not return value of type string, its return declaration is ": int"

3) Test\Preview\GeneratorTest::testGetNewPreview
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

4) Test\Preview\GeneratorTest::testCorrectSize with data set #0 (1024, 2048, 512, 512, false, 'fill', 256, 512)
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

5) Test\Preview\GeneratorTest::testCorrectSize with data set #1 (1024, 2048, 512, 512, false, 'cover', 512, 1024)
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

6) Test\Preview\GeneratorTest::testCorrectSize with data set #2 (1024, 2048, 512, 512, true, 'fill', 1024, 1024)
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

7) Test\Preview\GeneratorTest::testCorrectSize with data set #3 (1024, 2048, 512, 512, true, 'cover', 1024, 1024)
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

8) Test\Preview\GeneratorTest::testCorrectSize with data set #4 (1024, 2048, -1, 512, false, 'cover', 256, 512)
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

9) Test\Preview\GeneratorTest::testCorrectSize with data set #5 (1024, 2048, 512, -1, false, 'fill', 512, 1024)
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

10) Test\Preview\GeneratorTest::testCorrectSize with data set #6 (1024, 2048, 250, 1100, true, 'cover', 256, 1126)
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

11) Test\Preview\GeneratorTest::testCorrectSize with data set #7 (1024, 1100, 250, 1100, true, 'cover', 250, 1100)
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

12) Test\Preview\GeneratorTest::testCorrectSize with data set #8 (1024, 2048, 4096, 2048, false, 'fill', 1024, 2048)
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

13) Test\Preview\GeneratorTest::testCorrectSize with data set #9 (1024, 2048, 4096, 2048, false, 'cover', 1024, 2048)
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

14) Test\Preview\GeneratorTest::testCorrectSize with data set #10 (2048, 1024, 512, 512, false, 'fill', 512, 256)
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

15) Test\Preview\GeneratorTest::testCorrectSize with data set #11 (2048, 1024, 512, 512, false, 'cover', 1024, 512)
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

16) Test\Preview\GeneratorTest::testCorrectSize with data set #12 (2048, 1024, 512, 512, true, 'fill', 1024, 1024)
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

17) Test\Preview\GeneratorTest::testCorrectSize with data set #13 (2048, 1024, 512, 512, true, 'cover', 1024, 1024)
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

18) Test\Preview\GeneratorTest::testCorrectSize with data set #14 (2048, 1024, -1, 512, false, 'fill', 1024, 512)
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

19) Test\Preview\GeneratorTest::testCorrectSize with data set #15 (2048, 1024, 512, -1, false, 'cover', 512, 256)
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

20) Test\Preview\GeneratorTest::testCorrectSize with data set #16 (2048, 1024, 4096, 1024, true, 'fill', 2048, 512)
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

21) Test\Preview\GeneratorTest::testCorrectSize with data set #17 (2048, 1024, 4096, 1024, true, 'cover', 2048, 512)
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

22) Test\Preview\GeneratorTest::testCorrectSize with data set #18 (2048, 1024, 32, 32, false, 'fill', 64, 32)
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

23) Test\Preview\GeneratorTest::testCorrectSize with data set #19 (2048, 1024, 32, 32, false, 'cover', 64, 32)
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

24) Test\Preview\GeneratorTest::testCorrectSize with data set #20 (2048, 1024, 32, 32, true, 'fill', 64, 64)
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

25) Test\Preview\GeneratorTest::testCorrectSize with data set #21 (2048, 1024, 32, 32, true, 'cover', 64, 64)
Cannot stub or mock class or interface "Test\Preview\IImage" which does not exist

26) OCA\Settings\Tests\AppInfo\ManagerTest::testGetPersonalSectionsEmptySection
assertArraySubset() is deprecated and will be removed in PHPUnit 9.

27) OCA\DAV\Tests\unit\BackgroundJob\UpdateCalendarResourcesRoomsBackgroundJobTest::testRun
Passing an array of interface names to createMock() for creating a test double that implements multiple interfaces is deprecated and will no longer be supported in PHPUnit 9.
Passing an array of interface names to getMockBuilder() for creating a test double that implements multiple interfaces is deprecated and will no longer be supported in PHPUnit 9.

28) OCA\DAV\Tests\Command\MoveCalendarTest::testMove
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.

29) ExpirationTest::testParseRetentionObligation with data set #0 ('disabled', null, null, null)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

30) ExpirationTest::testParseRetentionObligation with data set #1 ('auto', 30, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

31) ExpirationTest::testParseRetentionObligation with data set #2 ('auto,auto', 30, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

32) ExpirationTest::testParseRetentionObligation with data set #3 ('auto, auto', 30, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

33) ExpirationTest::testParseRetentionObligation with data set #4 ('auto, 3', -1, 3, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

34) ExpirationTest::testParseRetentionObligation with data set #5 ('5, auto', 5, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

35) ExpirationTest::testParseRetentionObligation with data set #6 ('3, 5', 3, 5, false)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

36) ExpirationTest::testParseRetentionObligation with data set #7 ('10, 3', 10, 10, false)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

37) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #0 ('disabled', null, null, null)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

38) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #1 ('auto', -1, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

39) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #2 ('auto,auto', -1, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

40) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #3 ('auto, auto', -1, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

41) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #4 ('auto, 3', -1, 3, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

42) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #5 ('5, auto', 5, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

43) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #6 ('3, 5', 3, 5, false)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

44) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #7 ('10, 3', 10, 10, false)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

45) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #8 ('g,a,r,b,a,g,e', -1, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

46) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #9 ('-3,8', -1, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.

47) OCA\Settings\Tests\Mailer\NewUserMailHelperTest::testGenerateTemplateWithPasswordResetToken
Method getTime may not return value of type string, its return declaration is ": int"

48) OCA\UpdateNotification\Tests\Notification\BackgroundJobTest::testCreateNotifications with data set #1 ('app2', '1.0.1', '1.0.0', '1.0.0', true, array('user1'), array(array('user1')))
Method notify may not return value of type Mock_INotification_e917b81f, its return declaration is ": void"

49) OCA\UpdateNotification\Tests\Notification\BackgroundJobTest::testCreateNotifications with data set #2 ('app3', '1.0.1', false, false, true, array('user2', 'user3'), array(array('user2'), array('user3')))
Method notify may not return value of type Mock_INotification_e917b81f, its return declaration is ": void"

sqlite

Show full log

There was 1 error:

1) OCA\Files_Sharing\Tests\EtagPropagationTest::testRecipientDeleteInShare
Error: Call to a member function getMountPoint() on null

/drone/src/lib/private/Share20/Manager.php:305
/drone/src/lib/private/Share20/Manager.php:707
/drone/src/apps/files_sharing/tests/EtagPropagationTest.php:142
/drone/src/apps/files_sharing/tests/PropagationTestCase.php:42

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

mariadb10.1-php7.2

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\ScannerTest::testFile
Failed asserting that true matches expected false.

/drone/src/tests/lib/Files/Cache/ScannerTest.php:57

mysql8.0-php7.2

• cancelled - typically means that the tests took longer than the drone CI allows them to run

[MorrisJobke]

This was only added to stable19: #19495