Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable17] Ensured large image is unloaded from memory when generating previews #22187

Closed
wants to merge 2 commits into from

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Aug 11, 2020

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #22008

elijahnyp and others added 2 commits August 11, 2020 09:31
Signed-off-by: Elijah Martin-Merrill <elijah@nyp-itsours.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 17.0.10 milestone Aug 11, 2020
@rullzer rullzer added the 3. to review Waiting for reviews label Aug 11, 2020
@faily-bot
Copy link

faily-bot bot commented Aug 11, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31611: failure

webpack-build

nodb

postgres9-php7.3

Show full log
There was 1 failure:

1) OCA\Files_Versions\Tests\VersioningTest::testRestoreMovedShare
File content has not changed
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'version 2'
+'version 1'

/drone/src/apps/files_versions/tests/VersioningTest.php:725

@MorrisJobke
Copy link
Member

This was only added to stable19: #19495

@MorrisJobke MorrisJobke deleted the backport/22008/stable17 branch August 13, 2020 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants