[stable20] Only attempt to move to trash if a file is not in appdata #24483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
backportbot-nextcloud
bot
requested review from
ChristophWurst,
icewind1991,
juliusknorr,
MorrisJobke and
rullzer
MorrisJobke
approved these changes
Dec 1, 2020
juliusknorr
approved these changes
Dec 1, 2020
juliusknorr
added
4. to release
Signed-off-by: Julius Härtl <jus@bitgrid.net>
MorrisJobke
force-pushed
the
backport/24094/stable20
branch
from
74c329c to
7d786a4
Compare
|
I have an external SMB share mounted for my user and I specify the folder as "_External\Videos" (I use _External just to keep them all in one place), but this code does not exclude it from moving deleted files to the trash. When you have 10GB+ files this becomes unmaintainable especially as it has to move file across the LAN from the share to the local storage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #24094