Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable20] Only execute plain mimetype check for directories and do the fallback… #24517

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #24459

… only for non-directories

Ref #23096

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Dec 2, 2020
@faily-bot
Copy link

faily-bot bot commented Dec 2, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 91: failure

mysql5.6-php7.2

Show full log
There was 1 error:

1) OCA\DAV\Tests\unit\Connector\Sabre\RequestTest\EncryptionUploadTest::testChunkedUploadOutOfOrder
TypeError: Argument 2 passed to OCA\DAV\Events\CalendarCreatedEvent::__construct() must be of the type array, null given, called in /drone/src/apps/dav/lib/CalDAV/CalDavBackend.php on line 813

/drone/src/apps/dav/lib/Events/CalendarCreatedEvent.php:51
/drone/src/apps/dav/lib/CalDAV/CalDavBackend.php:813
/drone/src/apps/dav/lib/HookManager.php:157
/drone/src/apps/dav/lib/AppInfo/Application.php:131
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:264
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:239
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:73
/drone/src/lib/private/EventDispatcher/SymfonyAdapter.php:85
/drone/src/lib/private/User/Session.php:569
/drone/src/lib/private/User/Session.php:415
/drone/src/lib/private/User/Session.php:624
/drone/src/lib/private/User/Session.php:367
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/Auth.php:84
/drone/src/3rdparty/sabre/dav/lib/DAV/Auth/Plugin.php:193
/drone/src/3rdparty/sabre/dav/lib/DAV/Auth/Plugin.php:144
/drone/src/3rdparty/sabre/event/lib/WildcardEmitterTrait.php:89
/drone/src/3rdparty/sabre/dav/lib/DAV/Server.php:458
/drone/src/3rdparty/sabre/dav/lib/DAV/Server.php:251
/drone/src/3rdparty/sabre/dav/lib/DAV/Server.php:319
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/RequestTestCase.php:134
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/RequestTestCase.php:116
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/UploadTest.php:144

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

@MorrisJobke MorrisJobke mentioned this pull request Dec 3, 2020
@rullzer rullzer merged commit f6c2413 into stable20 Dec 3, 2020
@rullzer rullzer deleted the backport/24459/stable20 branch December 3, 2020 08:37
@rullzer rullzer mentioned this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants