Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contact hyperlink issue fixed #31824

Conversation

devsekar-1992
Copy link
Contributor

@devsekar-1992 devsekar-1992 commented Apr 4, 2022

Close #24807

Signed-off-by: Gnana Sekar developersekar1992@gmail.com

@szaimen szaimen changed the title New Branch Commit contact hyperlink issue fixed Apr 4, 2022
@szaimen szaimen requested review from Pytal, a team, PVince81 and szaimen and removed request for a team April 4, 2022 13:10
@szaimen szaimen added this to the Nextcloud 24 milestone Apr 4, 2022
@szaimen
Copy link
Contributor

szaimen commented Apr 4, 2022

@devsekar-1992 it seems like the compiled js is not up-to-date. Could you please compile it and push it to this branch? Thank you! :)

@devsekar-1992
Copy link
Contributor Author

@devsekar-1992 it seems like the compiled js is not up-to-date. Could you please compile it and push it to this branch? Thank you! :)

Am I need to run make build-js-production?

@artonge
Copy link
Contributor

artonge commented Apr 4, 2022

Am I need to run make build-js-production?

That or npm ci && npm run build

@devsekar-1992
Copy link
Contributor Author

Am I need to run make build-js-production?

That or npm ci && npm run build

After run this command, no changes to commit and push

@szaimen
Copy link
Contributor

szaimen commented Apr 4, 2022

After run this command, no changes to commit and push

I will rebase your branch now. Please try again afterwards.

@szaimen szaimen force-pushed the contact-popover-hyperlink-issue branch from 7d91fcc to e398d24 Compare April 4, 2022 15:55
@szaimen
Copy link
Contributor

szaimen commented Apr 4, 2022

After run this command, no changes to commit and push

I will rebase your branch now. Please try again afterwards.

@devsekar-1992 Please try again now :)

@devsekar-1992
Copy link
Contributor Author

After run this command, no changes to commit and push

I will rebase your branch now. Please try again afterwards.

@devsekar-1992 Please try again now :)

Need to pull my branch and run the command right?

@artonge
Copy link
Contributor

artonge commented Apr 4, 2022

After run this command, no changes to commit and push

I will rebase your branch now. Please try again afterwards.

@devsekar-1992 Please try again now :)

Need to pull my branch and run the command right?

Yes, git pull --rebase

Could you also change the commit message to make it something more descriptive ? :)

@devsekar-1992
Copy link
Contributor Author

git pull --rebase

Nope still no changes in git status

@Pytal
Copy link
Member

Pytal commented Apr 5, 2022

/compile amend /

@devsekar-1992
Copy link
Contributor Author

@szaimen Can you please help on this conflict issue?

@blizzz blizzz mentioned this pull request Apr 7, 2022
Signed-off-by: Gnana Sekar <developersekar1992@gmail.com>
@szaimen szaimen force-pushed the contact-popover-hyperlink-issue branch from e398d24 to 22c19c4 Compare April 7, 2022 14:40
@szaimen
Copy link
Contributor

szaimen commented Apr 7, 2022

That or npm ci && npm run build

@devsekar-1992 please try that again now :)

@devsekar-1992
Copy link
Contributor Author

devsekar-1992 commented Apr 7, 2022

That or npm ci && npm run build

@devsekar-1992 please try that again now :)

Thanks. Conflicts has been fixed and I ran this script. it shows nothing to commit

@szaimen
Copy link
Contributor

szaimen commented Apr 7, 2022

That or npm ci && npm run build

@devsekar-1992 please try that again now :)

Thanks. Conflicts has been fixed and I ran this script. it shows nothing to commit

Then the command is probably not working for you. Do you see some errors when running this command?

@devsekar-1992
Copy link
Contributor Author

That or npm ci && npm run build

@devsekar-1992 please try that again now :)

Thanks. Conflicts has been fixed and I ran this script. it shows nothing to commit

Then the command is probably not working for you. Do you see some errors when running this command?

No . please see below image

image

@szaimen
Copy link
Contributor

szaimen commented Apr 7, 2022

Okay, does git add . work?

@devsekar-1992
Copy link
Contributor Author

Okay, does git add . work?

show only .rnd file

@szaimen
Copy link
Contributor

szaimen commented Apr 7, 2022

Okay, does git add . work?

show only .rnd file

no idea then :/


lets try another approach: @skjnldsv can you please invite @devsekar-1992 to the org? I can then push the changes to a branch in this repo and we can use the compile bot :)

@artonge
Copy link
Contributor

artonge commented Apr 11, 2022

@devsekar-1992

Looks like you are having trouble rebasing. Can you checkout the remote branch into another local branch?
Something like that should work (assuming you have a remote called devsekar-1992 locally):

git checkout -b contact-popover-hyperlink-issue-2 --track devsekar-1992/contact-popover-hyperlink-issue

Then you can work on this fresh branch :)

@devsekar-1992
Copy link
Contributor Author

```shell
git checkout -b contact-popover-hyperlink-issue-2 --track devsekar-1992/contact-popover-hyperlink-issue

git checkout -b contact-popover-hyperlink-issue-2 --track origin/contact-popover-hyperlink-issue
use above command and run npm ci & npm run build command.

Created a new branch pull request
Conflicts
#31928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contacts menu, more intuitive link to contact details
4 participants