-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contact hyperlink issue fixed #31824
contact hyperlink issue fixed #31824
Conversation
@devsekar-1992 it seems like the compiled js is not up-to-date. Could you please compile it and push it to this branch? Thank you! :) |
Am I need to run make build-js-production? |
That or |
After run this command, no changes to commit and push |
I will rebase your branch now. Please try again afterwards. |
7d91fcc
to
e398d24
Compare
@devsekar-1992 Please try again now :) |
Need to pull my branch and run the command right? |
Yes, Could you also change the commit message to make it something more descriptive ? :) |
Nope still no changes in git status |
/compile amend / |
@szaimen Can you please help on this conflict issue? |
Signed-off-by: Gnana Sekar <developersekar1992@gmail.com>
e398d24
to
22c19c4
Compare
@devsekar-1992 please try that again now :) |
Thanks. Conflicts has been fixed and I ran this script. it shows nothing to commit |
Then the command is probably not working for you. Do you see some errors when running this command? |
No . please see below image |
Okay, does |
show only .rnd file |
no idea then :/ lets try another approach: @skjnldsv can you please invite @devsekar-1992 to the org? I can then push the changes to a branch in this repo and we can use the compile bot :) |
Looks like you are having trouble rebasing. Can you checkout the remote branch into another local branch? git checkout -b contact-popover-hyperlink-issue-2 --track devsekar-1992/contact-popover-hyperlink-issue Then you can work on this fresh branch :) |
Created a new branch pull request |
Close #24807
Signed-off-by: Gnana Sekar developersekar1992@gmail.com