-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap contact search result in a link #31931
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
enhancement
3. to review
Waiting for reviews
feature: contacts menu
labels
Apr 11, 2022
Signed-off-by: Gnana Sekar <developersekar1992@gmail.com> Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
contact-popover-hyperlink-issue-2
branch
from
April 11, 2022 15:13
acef539
to
7696e3f
Compare
szaimen
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good but didn't test
szaimen
requested review from
a team,
PVince81,
skjnldsv and
Pytal
and removed request for
a team
April 11, 2022 15:27
@devsekar-1992 can you check that the change is still good ? |
Yes @artonge |
Pytal
approved these changes
Apr 11, 2022
Pytal
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Apr 11, 2022
Thank you @devsekar-1992 ! Sorry it was such a drag for you, hopefully it will be smoother next time! :) |
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
enhancement
feature: contacts menu
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersede #31824
Fix #24807