Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly reset pw expiration #31965

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

PVince81
Copy link
Member

When requesting a new password for share by mail link, now we correctly
reset the expiration date.

Signed-off-by: Vincent Petry vincent@nextcloud.com

When requesting a new password for share by mail link, now we correctly
reset the expiration date.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81
Copy link
Member Author

I've also added a commit to deafult to permanent passwords, no expiration.
At least for now in Nextcloud 24 because we're worried that users are surprised when they enter a password manually and then they expire.

We will need to recheck the feature in detail and decide how to tweak it, and then we can change the default.

@PVince81 PVince81 marked this pull request as ready for review April 13, 2022 14:12
@PVince81 PVince81 self-assigned this Apr 13, 2022
@PVince81 PVince81 added this to the Nextcloud 24 milestone Apr 13, 2022
@skjnldsv skjnldsv added the 4. to release Ready to be released and/or waiting for tests to finish label Apr 13, 2022
@PVince81 PVince81 merged commit 964bc57 into master Apr 13, 2022
@PVince81 PVince81 deleted the bugfix/31951/fix-share-by-mail-expiration-reset branch April 13, 2022 16:21
@blizzz blizzz mentioned this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: sharing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants