Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docxf and form mimetypes #32481

Merged
merged 3 commits into from
Jun 7, 2022
Merged

Conversation

luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented May 18, 2022

Add new mime types for onlyoffice form template and form files

nextcloud/office#17

lib/private/Repair/RepairMimeTypes.php Outdated Show resolved Hide resolved
lib/private/Repair/RepairMimeTypes.php Outdated Show resolved Hide resolved
@juliusknorr

This comment was marked as resolved.

@luka-nextcloud luka-nextcloud force-pushed the feature/add-docxf-form-mimetypes branch 2 times, most recently from 68886b5 to f40d78d Compare May 27, 2022 12:06
@luka-nextcloud luka-nextcloud self-assigned this Jun 1, 2022
@juliusknorr
Copy link
Member

@luka-nextcloud The icon files still seem to be missing from the diff ;)

@luka-nextcloud luka-nextcloud force-pushed the feature/add-docxf-form-mimetypes branch from f40d78d to b79bc46 Compare June 3, 2022 14:08
@luka-nextcloud
Copy link
Contributor Author

luka-nextcloud commented Jun 3, 2022

@luka-nextcloud The icon files still seem to be missing from the diff ;)

It was working fine, but I noticed that icons are missing now.

@luka-nextcloud
Copy link
Contributor Author

@juliushaertl Please check again.

@juliusknorr juliusknorr force-pushed the feature/add-docxf-form-mimetypes branch from 4fd3c03 to 39d5280 Compare June 4, 2022 07:24
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works

@juliusknorr
Copy link
Member

I pushed a commit to make the signature check a bit cleaner and easier to update with inline instructions.

@juliusknorr juliusknorr requested review from a team, icewind1991 and skjnldsv and removed request for a team June 7, 2022 11:33
@juliusknorr juliusknorr added this to the Nextcloud 25 milestone Jun 7, 2022
@juliusknorr juliusknorr added enhancement 3. to review Waiting for reviews labels Jun 7, 2022
@luka-nextcloud
Copy link
Contributor Author

@juliushaertl Thanks for your help.

luka-nextcloud and others added 3 commits June 7, 2022 21:54
signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the feature/add-docxf-form-mimetypes branch from 39d5280 to 50ed84f Compare June 7, 2022 19:54
@juliusknorr juliusknorr merged commit 0f6fc32 into master Jun 7, 2022
@juliusknorr juliusknorr deleted the feature/add-docxf-form-mimetypes branch June 7, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants