Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable23] Use stored user for PasswordUpdatedEvent #32975

Merged
merged 1 commit into from
Jul 5, 2022
Merged

[stable23] Use stored user for PasswordUpdatedEvent #32975

merged 1 commit into from
Jul 5, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #32016

@artonge @backportbot-nextcloud
Use stored user for PasswordUpdatedEvent
48477ba 
When handling PasswordUpdatedEvent event, we are calling getLoginName which does not exists.

This PR adds a condition to use the previously stored user when handling PasswordUpdatedEvent.

Signed-off-by: Louis Chemineau <louis@chmn.me>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 23.0.7 milestone Jun 22, 2022
@artonge artonge requested a review from blizzz June 23, 2022 08:38
@blizzz blizzz added the 4. to release Ready to be released and/or waiting for tests to finish label Jun 24, 2022
@blizzz
Copy link
Member

blizzz commented Jun 24, 2022

Tests failing, not sure whether related?

artonge
artonge approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those tests are triggered on specific files change and are always failing. They were failing on the parent PR.

@blizzz blizzz merged commit 0882642 into stable23 Jul 5, 2022
@blizzz blizzz deleted the backport/32016/stable23 branch July 5, 2022 10:31
@skjnldsv skjnldsv mentioned this pull request Jul 5, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@blizzz blizzz blizzz approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: external storage
Projects
None yet
Milestone
Nextcloud 23.0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@blizzz @artonge