Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change header semantic in the user status dialog #35455

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Change header semantic in the user status dialog #35455

merged 1 commit into from
Nov 29, 2022

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Nov 28, 2022 •
edited
Loading

Fixes #35098

Before After
Screenshot from 2022-11-28 17-12-45 Screenshot from 2022-11-28 17-13-42

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Nov 28, 2022
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Nov 28, 2022
@szaimen
Copy link
Contributor

szaimen commented Nov 28, 2022

@JuliaKirschenheuter can you please post a before after screeenshot? Thanks :)

szaimen
szaimen approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@JuliaKirschenheuter
Copy link
Contributor Author

/compile amend /

@JuliaKirschenheuter @nextcloud-command
Change header semantic in the user status dialog
af14bbb 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/fix-35098-headings_need_to_be_h2 branch from 278df4c to af14bbb Compare November 29, 2022 07:29
@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable25

@ChristophWurst ChristophWurst merged commit e450bc4 into master Nov 29, 2022
@ChristophWurst ChristophWurst deleted the fix/fix-35098-headings_need_to_be_h2 branch November 29, 2022 08:47
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 29, 2022
Merged
1 task
@AndyScherzinger AndyScherzinger added this to the Nextcloud 26 milestone Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews accessibility
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.

Headings need to be h2
5 participants
@JuliaKirschenheuter @szaimen @ChristophWurst @skjnldsv @AndyScherzinger