Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Fix type of PreviewController::$userId #35577

Merged
merged 1 commit into from
Dec 19, 2022
Merged

[stable25] Fix type of PreviewController::$userId #35577

merged 1 commit into from
Dec 19, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #35385

@backportbot-nextcloud backportbot-nextcloud bot added bug php Pull requests that update Php code labels Dec 3, 2022
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 25.0.2 milestone Dec 3, 2022
@blizzz blizzz mentioned this pull request Dec 6, 2022
Merged
1 task
@blizzz
Copy link
Member

blizzz commented Dec 6, 2022

moving to 25.0.3

PVince81
PVince81 approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@come-nc
Copy link
Contributor

come-nc commented Dec 19, 2022

/rebase

@pulsejet @come-nc
Fix type of PreviewController::$userId
64a1bce 
Can be null if not logged in; currently crashes

Signed-off-by: Varun Patil <varunpatil@ucla.edu>
@PVince81 PVince81 merged commit 1fc83de into stable25 Dec 19, 2022
@PVince81 PVince81 deleted the backport/35385/stable25 branch December 19, 2022 11:12
@skjnldsv skjnldsv mentioned this pull request Jan 6, 2023
Merged
5 tasks
@blizzz blizzz mentioned this pull request Jan 11, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@PVince81 PVince81 PVince81 approved these changes

@artonge artonge Awaiting requested review from artonge

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

Assignees
No one assigned
Labels
bug php Pull requests that update Php code
Projects
None yet
Milestone
Nextcloud 25.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@blizzz @come-nc @PVince81 @pulsejet