Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Fix interned strings buffer check if 0 free bytes #36292

Merged
merged 1 commit into from
Jan 23, 2023
Merged

[stable25] Fix interned strings buffer check if 0 free bytes #36292

merged 1 commit into from
Jan 23, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #36278

@MichaIng @backportbot-nextcloud
Fix interned strings buffer check if 0 free bytes
22459ff 
With #32902 it was meant to be avoided to recommend raising the interned strings buffer size above a quarter of the total OPcache size. This works as long as there is at least 1 byte free, but does not apply if the buffer is filled completely.

This commit switches the conditions so that the interned strings buffer size must be smaller than a quarter of the total OPcache size for the warning to be shown. That the buffer must be either filled completely or by more than 90% remains untouched.

Signed-off-by: MichaIng <micha@dietpi.com>
@backportbot-nextcloud backportbot-nextcloud bot added bug php Pull requests that update Php code labels Jan 23, 2023
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 25.0.4 milestone Jan 23, 2023
@MichaIng MichaIng enabled auto-merge January 23, 2023 09:54
@szaimen szaimen disabled auto-merge January 23, 2023 11:27
@szaimen szaimen merged commit e50d0d2 into stable25 Jan 23, 2023
@szaimen szaimen deleted the backport/36278/stable25 branch January 23, 2023 11:27
@blizzz blizzz mentioned this pull request Feb 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@MichaIng MichaIng MichaIng approved these changes

@come-nc come-nc Awaiting requested review from come-nc

Assignees
No one assigned
Labels
bug php Pull requests that update Php code
Projects
None yet
Milestone
Nextcloud 25.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaIng @szaimen