Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort shares by title and then creation date #36933

Closed
wants to merge 6 commits into from
Closed

Sort shares by title and then creation date #36933

wants to merge 6 commits into from

Conversation

SamantaTarun
Copy link

@SamantaTarun SamantaTarun commented Mar 1, 2023

Please don't close the PR. Let me know if any changes are required.

Summary

Let me know if any changes are required.

Checklist

@solracsf solracsf added this to the Nextcloud 26 milestone Mar 1, 2023
@solracsf solracsf added the 3. to review Waiting for reviews label Mar 1, 2023
@solracsf solracsf changed the title commit for testing Sort shares by title and then creation date Mar 1, 2023
Signed-off-by: Tarun Samanta <55488549+tarunsamanta2k20@users.noreply.github.com>
@szaimen szaimen requested review from a team, skjnldsv, Pytal and szaimen and removed request for a team March 6, 2023 23:04
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See

apps/files_sharing/src/views/SharingTab.vue Outdated Show resolved Hide resolved
@SamantaTarun SamantaTarun requested review from skjnldsv and removed request for Pytal and szaimen March 7, 2023 13:21
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 7, 2023
@blizzz blizzz mentioned this pull request Mar 7, 2023
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 7, 2023
@SamantaTarun
Copy link
Author

@skjnldsv could you please test it once?

@skjnldsv skjnldsv removed their request for review March 16, 2023 10:10
@skjnldsv
Copy link
Member

@skjnldsv could you please test it once?

See comment #36933 (comment)

@szaimen
Copy link
Contributor

szaimen commented Mar 16, 2023

@tarunsamanta2k20 I would recommend https://github.com/szaimen/nextcloud-easy-test for testing the changes you've made.

If you've installed docker locally, you should be able to test it with

docker run -it \
-e SERVER_BRANCH=tarunsamanta2k20:tarun_samanta/#36906 \
-e COMPILE_SERVER=1 \
--name nextcloud-easy-test \
-p 127.0.0.1:8443:443 \
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" \
ghcr.io/szaimen/nextcloud-easy-test:latest

More instructions are here: https://github.com/szaimen/nextcloud-easy-test#nextcloud-easy-test-instance

@SamantaTarun
Copy link
Author

@szaimen let me try once.

@SamantaTarun
Copy link
Author

SamantaTarun commented Mar 17, 2023

@szaimen somehow I managed to run the application but tell me how to add some shares. Because share tab is empty right now.

@szaimen
Copy link
Contributor

szaimen commented Mar 17, 2023

someone I managed to run the application but tell me how to add some shares.

Simply create a few users and then share to them and also create link shares?

@SamantaTarun
Copy link
Author

@szaimen let see tomorrow.

@SamantaTarun
Copy link
Author

@skjnldsv please check my recent commit, i have tested it, it's working fine.

@SamantaTarun SamantaTarun requested a review from skjnldsv March 18, 2023 21:28
@skjnldsv skjnldsv removed their request for review March 19, 2023 09:15
@SamantaTarun SamantaTarun requested a review from skjnldsv March 25, 2023 22:39
@skjnldsv
Copy link
Member

@tarunsamanta2k20 I'm sorry, but I cannot review or accept this PR

  • You keep adding more commits instead of amending/squashing
  • You are not writing commits descriptions
  • You did not test the work you've been putting
  • You didn't even sign-off your work despite me linking our contributing guidelines and it being written down

This is too light as a contribution in my opinion 😕
I'm being straightforward, but you seem to have been contributing to Github repositories for multiple months now, so I assume you know how contributing works in general :)
I'm removing myself from reviewer, I don't have time to guide further. I will let others from the community take over 👍

@skjnldsv skjnldsv removed their request for review March 28, 2023 05:57
@SamantaTarun
Copy link
Author

@tarunsamanta2k20 I'm sorry, but I cannot review or accept this PR

  • You keep adding more commits instead of amending/squashing
  • You are not writing commits descriptions
  • You did not test the work you've been putting
  • You didn't even sign-off your work despite me linking our contributing guidelines and it being written down

This is too light as a contribution in my opinion 😕 I'm being straightforward, but you seem to have been contributing to Github repositories for multiple months now, so I assume you know how contributing works in general :) I'm removing myself from reviewer, I don't have time to guide further. I will let others from the community take over 👍
@skjnldsv
Shall I modify this PR or create a new PR?

@SamantaTarun SamantaTarun requested a review from skjnldsv March 28, 2023 14:10
@SamantaTarun
Copy link
Author

@skjnldsv shall i create a new fresh PR?

@SamantaTarun
Copy link
Author

SamantaTarun commented Mar 29, 2023

@skjnldsv please delete this PR. Don't close it. Just delete it. I am opening a fresh PR for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort shares by title and then creation date
5 participants