-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort shares by title and then creation date #36933
Conversation
Signed-off-by: Tarun Samanta <55488549+tarunsamanta2k20@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See
@skjnldsv could you please test it once? |
See comment #36933 (comment) |
@tarunsamanta2k20 I would recommend https://github.com/szaimen/nextcloud-easy-test for testing the changes you've made. If you've installed docker locally, you should be able to test it with
More instructions are here: https://github.com/szaimen/nextcloud-easy-test#nextcloud-easy-test-instance |
@szaimen let me try once. |
@szaimen somehow I managed to run the application but tell me how to add some shares. Because share tab is empty right now. |
Simply create a few users and then share to them and also create link shares? |
@szaimen let see tomorrow. |
@skjnldsv please check my recent commit, i have tested it, it's working fine. |
@tarunsamanta2k20 I'm sorry, but I cannot review or accept this PR
This is too light as a contribution in my opinion 😕 |
|
@skjnldsv shall i create a new fresh PR? |
@skjnldsv please delete this PR. Don't close it. Just delete it. I am opening a fresh PR for this issue. |
Please don't close the PR. Let me know if any changes are required.
Summary
Let me know if any changes are required.
Checklist