Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sharing flow #39472

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Improve sharing flow #39472

merged 1 commit into from
Aug 30, 2023

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Jul 19, 2023

Summary

Resolves: #26691

@nfebe nfebe force-pushed the 26691-improve-sharing-design-flow branch 4 times, most recently from 7cf0c6c to f1e8fda Compare July 28, 2023 09:02
@nfebe nfebe force-pushed the 26691-improve-sharing-design-flow branch 9 times, most recently from d0ab2b1 to c10f540 Compare August 7, 2023 00:14
@nfebe
Copy link
Contributor Author

nfebe commented Aug 7, 2023

Share Details View

Share details Share advanced (optional checks off) Share details advanced (optional checks on)
share-details share-details-advanced-checks-off share-details-advanced

@AndyScherzinger AndyScherzinger added enhancement design Design, UI, UX, etc. 2. developing Work in progress labels Aug 7, 2023
@nimishavijay

This comment was marked as resolved.

Sign in to view
jancborchardt
jancborchardt reviewed Aug 8, 2023
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The folder name under "Edit share link" can be removed, since it's already there in the top of the sidebar. Instead, if there is a share label set that can be shown in place of the folder name

→ Reviews moved to comment below

@nfebe nfebe force-pushed the 26691-improve-sharing-design-flow branch from c10f540 to c029526 Compare August 9, 2023 09:58
@nfebe nfebe force-pushed the 26691-improve-sharing-design-flow branch from c029526 to 058db4c Compare August 9, 2023 19:04
@nfebe

This comment was marked as resolved.

Sign in to view
jancborchardt

This comment was marked as resolved.

Sign in to view

szaimen

This comment was marked as resolved.

Sign in to view

@nfebe nfebe force-pushed the 26691-improve-sharing-design-flow branch 2 times, most recently from 6e7f0d4 to 7df89e8 Compare August 13, 2023 16:16
@artonge
Copy link
Contributor

artonge commented Aug 30, 2023

Backport to stable27: #40166

@artonge artonge force-pushed the 26691-improve-sharing-design-flow branch from 488dcfb to 79f6263 Compare August 30, 2023 16:18
@nfebe nfebe merged commit c24d6df into master Aug 30, 2023
40 checks passed
@nfebe nfebe deleted the 26691-improve-sharing-design-flow branch August 30, 2023 21:18
@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Aug 31, 2023
@AndyScherzinger AndyScherzinger mentioned this pull request Aug 31, 2023
Closed
23 tasks
@artonge artonge mentioned this pull request Aug 31, 2023
Merged
@nfebe nfebe mentioned this pull request Sep 5, 2023
Merged
4 tasks
@ShGKme ShGKme mentioned this pull request Nov 6, 2023
Merged
6 tasks
@skjnldsv skjnldsv mentioned this pull request Jan 16, 2024
Closed
@ShGKme ShGKme mentioned this pull request Jun 17, 2024
Draft
7 tasks
nfebe added a commit that referenced this pull request Jun 24, 2024
@nfebe
refactor(SharingInput): Remove unused addShare
0168a8b 
The new sharing flow since NC27 requires that users open the sharing details tab and
customize their share before creating it.

In #39472 the work of `addShare` was handed down to
`openSharingDetails` that opens the sharing details tab for the user to customize and manually
creat their share.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this pull request Jun 24, 2024
@nfebe
refactor(SharingInput): Remove unused addShare
45da8a0 
The new sharing flow since NC27 requires that users open the sharing details tab and
customize their share before creating it.

In #39472 the work of `addShare` was handed down to
`openSharingDetails` that opens the sharing details tab for the user to customize and manually
creat their share.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe nfebe mentioned this pull request Jun 24, 2024
Merged
1 task
nfebe added a commit that referenced this pull request Jul 1, 2024
@nfebe
refactor(SharingInput): Remove unused addShare
3b7883d 
The new sharing flow since NC27 requires that users open the sharing details tab and
customize their share before creating it.

In #39472 the work of `addShare` was handed down to
`openSharingDetails` that opens the sharing details tab for the user to customize and manually
creat their share.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this pull request Jul 3, 2024
@nfebe
refactor(SharingInput): Remove unused addShare
483d857 
The new sharing flow since NC27 requires that users open the sharing details tab and
customize their share before creating it.

In #39472 the work of `addShare` was handed down to
`openSharingDetails` that opens the sharing details tab for the user to customize and manually
creat their share.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
backportbot bot pushed a commit that referenced this pull request Jul 3, 2024
@nfebe @backportbot
refactor(SharingInput): Remove unused addShare
a604483 
The new sharing flow since NC27 requires that users open the sharing details tab and

customize their share before creating it.

In #39472 the work of `addShare` was handed down to

`openSharingDetails` that opens the sharing details tab for the user to customize and manually

creat their share.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

[skip ci]
backportbot bot pushed a commit that referenced this pull request Jul 3, 2024
@nfebe @backportbot
refactor(SharingInput): Remove unused addShare
5bf3301 
The new sharing flow since NC27 requires that users open the sharing details tab and

customize their share before creating it.

In #39472 the work of `addShare` was handed down to

`openSharingDetails` that opens the sharing details tab for the user to customize and manually

creat their share.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

[skip ci]
backportbot bot pushed a commit that referenced this pull request Jul 3, 2024
@nfebe @backportbot
refactor(SharingInput): Remove unused addShare
6764867 
The new sharing flow since NC27 requires that users open the sharing details tab and

customize their share before creating it.

In #39472 the work of `addShare` was handed down to

`openSharingDetails` that opens the sharing details tab for the user to customize and manually

creat their share.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

[skip ci]
nfebe added a commit that referenced this pull request Jul 3, 2024
@nfebe
refactor(SharingInput): Remove unused addShare
f2bfcdc 
The new sharing flow since NC27 requires that users open the sharing details tab and

customize their share before creating it.

In #39472 the work of `addShare` was handed down to

`openSharingDetails` that opens the sharing details tab for the user to customize and manually

creat their share.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this pull request Jul 3, 2024
@nfebe
refactor(SharingInput): Remove unused addShare
d505449 
The new sharing flow since NC27 requires that users open the sharing details tab and

customize their share before creating it.

In #39472 the work of `addShare` was handed down to

`openSharingDetails` that opens the sharing details tab for the user to customize and manually

creat their share.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this pull request Jul 3, 2024
@nfebe
refactor(SharingInput): Remove unused addShare
5962472 
The new sharing flow since NC27 requires that users open the sharing details tab and

customize their share before creating it.

In #39472 the work of `addShare` was handed down to

`openSharingDetails` that opens the sharing details tab for the user to customize and manually

creat their share.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this pull request Jul 3, 2024
@nfebe
refactor(SharingInput): Remove unused addShare
07d9ff8 
The new sharing flow since NC27 requires that users open the sharing details tab and

customize their share before creating it.

In #39472 the work of `addShare` was handed down to

`openSharingDetails` that opens the sharing details tab for the user to customize and manually

creat their share.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
AndyScherzinger pushed a commit that referenced this pull request Jul 11, 2024
@nfebe @AndyScherzinger
refactor(SharingInput): Remove unused addShare
8aea203 
The new sharing flow since NC27 requires that users open the sharing details tab and

customize their share before creating it.

In #39472 the work of `addShare` was handed down to

`openSharingDetails` that opens the sharing details tab for the user to customize and manually

creat their share.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this pull request Jul 11, 2024
@nfebe
refactor(SharingInput): Remove unused addShare
3e1384c 
The new sharing flow since NC27 requires that users open the sharing details tab and

customize their share before creating it.

In #39472 the work of `addShare` was handed down to

`openSharingDetails` that opens the sharing details tab for the user to customize and manually

creat their share.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this pull request Jul 11, 2024
@nfebe
refactor(SharingInput): Remove unused addShare
1e87d7c 
The new sharing flow since NC27 requires that users open the sharing details tab and

customize their share before creating it.

In #39472 the work of `addShare` was handed down to

`openSharingDetails` that opens the sharing details tab for the user to customize and manually

creat their share.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this pull request Jul 12, 2024
@nfebe
refactor(SharingInput): Remove unused addShare
ada08ed 
The new sharing flow since NC27 requires that users open the sharing details tab and

customize their share before creating it.

In #39472 the work of `addShare` was handed down to

`openSharingDetails` that opens the sharing details tab for the user to customize and manually

creat their share.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini left review comments

@juliusknorr juliusknorr juliusknorr left review comments

@jancborchardt jancborchardt jancborchardt left review comments

@artonge artonge artonge approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@szaimen szaimen szaimen left review comments

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees
No one assigned
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement feature: sharing javascript
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

🤝 Improvement to sharing design and flow
8 participants
@nfebe @nimishavijay @juliusknorr @jancborchardt @artonge @AndyScherzinger @marcoambrosini @szaimen