fix(twofactor): avoid DB error on Twofactor (en/dis)abled event #40472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lib/private/Authentication/TwoFactorAuth/Db/ProviderUserAssignmentDao.php
Fixed
Show fixed
Hide fixed
Altahrim
force-pushed
the
fix/aborted_pgsql_transaction_on_error
branch
2 times, most recently
from
dd88e15 to
54c9cbe
Compare
Altahrim
requested review from
ChristophWurst,
miaulalala,
nickvergessen and
st3iny
as code owners
lib/private/Authentication/TwoFactorAuth/Db/ProviderUserAssignmentDao.php
Show resolved
Hide resolved
nickvergessen
approved these changes
Sep 25, 2023
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
force-pushed
the
fix/aborted_pgsql_transaction_on_error
branch
from
54c9cbe to
4361019
Compare
ChristophWurst
approved these changes
Oct 6, 2023
Altahrim
added
4. to release
|
CI failure seems unrelated |
|
We are in freeze anyway, so you have to wait until friday |
|
/backport to stable27 |
|
/backport to stable26 |
This was referenced Oct 31, 2023
Altahrim
added a commit
that referenced
this pull request
Nov 15, 2023
…ransaction_on_error/stable27 [stable27] fix(twofactor): avoid DB error on Twofactor (en/dis)abled event #40472
Altahrim
removed
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With PostgreSQL, a transaction is aborted each time an error happen with the following message:
This PR avoid the error so the transaction can continue as expected.
Checklist