[stable27] fix(i18n): Changed grammar #41663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #41642 |
nickvergessen
changed the title
Valdnet
approved these changes
Nov 22, 2023
Has to wait until next releases |
Merged
rakekniven
force-pushed
the
rakekniven-patch-3
branch
from
3329762 to
135248c
Compare
|
moving to 27.1.6 |
|
Such a tiny change with no impact on any code is getting shifted? |
JS needs recompiling and the release is already in progress. |
|
Maybe you can set yourself a reminder for next friday, then rebase and recompile the JS assets and get it merged then. |
|
Also there would be no time for translation updates if squeezed in last minute. |
|
Please merge. |
|
/compile / |
nickvergessen
approved these changes
Jan 13, 2024
Merged
|
/compile / |
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
nickvergessen
force-pushed
the
rakekniven-patch-3
branch
from
1da1d2f to
3871f46
Compare
|
actually it was not compiling that failed, but the js unit test :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(i18n): Changed grammar