-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(share): use user timezone to parse share expiration date #42660
Conversation
/backport to stable28 |
5acb08a
to
ba5b51f
Compare
ba5b51f
to
011d392
Compare
3d2dbd4
to
35c7981
Compare
If an user in UTC+1 try to create a share at 00:00, it's day D for him, but D-1 for the server (UTC). This fix aims to apply the correct offset Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
35c7981
to
cc3a2c3
Compare
/backport to stable27 |
/backport to stable26 |
/skjnldsv-backport to stable26 |
/skjnldsv-backport to stable27 |
The backport to # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b backport/42660/stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick cc3a2c351a2db4c30a2f0dc1bde73ba024e88602
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/42660/stable26 Error: Validation Failed: {"resource":"PullRequest","code":"custom","message":"No commits between stable26 and backport/42660/stable26"} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
If an user in UTC+1 try to create a share at 00:00, it's day D for him, but D-1 for the server (UTC).
This fix aims to apply the correct offset.
Later, it will be better to also handle hours for share expiration.
Checklist