Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(share): use user timezone to parse share expiration date #42660

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Jan 9, 2024

Summary

If an user in UTC+1 try to create a share at 00:00, it's day D for him, but D-1 for the server (UTC).
This fix aims to apply the correct offset.

Later, it will be better to also handle hours for share expiration.

Checklist

@Altahrim Altahrim added bug 3. to review Waiting for reviews labels Jan 9, 2024
@Altahrim Altahrim added this to the Nextcloud 28.0.2 milestone Jan 9, 2024
@Altahrim Altahrim requested review from nfebe, skjnldsv and come-nc January 9, 2024 14:05
@Altahrim Altahrim self-assigned this Jan 9, 2024
@Altahrim
Copy link
Collaborator Author

Altahrim commented Jan 9, 2024

/backport to stable28

@Altahrim Altahrim force-pushed the fix/use-tz-for-share-expiration branch from 5acb08a to ba5b51f Compare January 9, 2024 14:17
@Altahrim Altahrim force-pushed the fix/use-tz-for-share-expiration branch from ba5b51f to 011d392 Compare January 9, 2024 14:20
@Altahrim Altahrim force-pushed the fix/use-tz-for-share-expiration branch 2 times, most recently from 3d2dbd4 to 35c7981 Compare January 9, 2024 15:00
If an user in UTC+1 try to create a share at 00:00, it's day D for him, but
D-1 for the server (UTC).
This fix aims to apply the correct offset

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim Altahrim force-pushed the fix/use-tz-for-share-expiration branch from 35c7981 to cc3a2c3 Compare January 9, 2024 16:28
@Altahrim Altahrim enabled auto-merge January 10, 2024 07:45
@Altahrim Altahrim requested a review from a team January 11, 2024 10:16
@Altahrim Altahrim merged commit bf59b63 into master Jan 15, 2024
50 checks passed
@Altahrim Altahrim deleted the fix/use-tz-for-share-expiration branch January 15, 2024 08:47
@Altahrim
Copy link
Collaborator Author

/backport to stable27

@Altahrim
Copy link
Collaborator Author

/backport to stable26

@nextcloud nextcloud deleted a comment from backportbot-nextcloud bot Jan 15, 2024
@nextcloud nextcloud deleted a comment from backportbot-nextcloud bot Jan 15, 2024
@skjnldsv
Copy link
Member

/skjnldsv-backport to stable26

@skjnldsv
Copy link
Member

/skjnldsv-backport to stable27

Copy link

backportbot bot commented Jan 15, 2024

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b backport/42660/stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick cc3a2c351a2db4c30a2f0dc1bde73ba024e88602

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/42660/stable26

Error: Validation Failed: {"resource":"PullRequest","code":"custom","message":"No commits between stable26 and backport/42660/stable26"}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
Archived in project
5 participants