Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] enh(core): replaced previous native a element with NcButton #42669

Merged
merged 1 commit into from
Jan 9, 2024
Merged

[stable28] enh(core): replaced previous native a element with NcButton #42669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 24 additions & 46 deletions core/src/components/Profile/PrimaryActionButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,23 +21,33 @@
-->

<template>
<a class="profile__primary-action-button"
:class="{ 'disabled': disabled }"
<NcButton type="primary"
:href="href"
alignment="center"
:target="target"
rel="noopener noreferrer nofollow"
v-on="$listeners">
<img class="icon"
:class="[icon, { 'icon-invert': colorPrimaryText === '#ffffff' }]"
:src="icon">
:disabled="disabled">
<template #icon>
<img class="icon"
aria-hidden="true"
:src="icon"
alt="">
</template>
<slot />
</a>
</NcButton>
</template>

<script>
export default {
import { defineComponent } from 'vue'
import { NcButton } from '@nextcloud/vue'
import { translate as t } from '@nextcloud/l10n'

export default defineComponent({
name: 'PrimaryActionButton',

components: {
NcButton,
},

props: {
disabled: {
type: Boolean,
Expand All @@ -58,46 +68,14 @@ export default {
},
},

computed: {
colorPrimaryText() {
// For some reason the returned string has prepended whitespace
return getComputedStyle(document.body).getPropertyValue('--color-primary-element-text').trim()
},
methods: {
t,
},
}
})
</script>

<style lang="scss" scoped>
.profile__primary-action-button {
font-size: var(--default-font-size);
font-weight: bold;
width: 188px;
height: 44px;
padding: 0 16px;
line-height: 44px;
text-align: center;
border-radius: var(--border-radius-pill);
color: var(--color-primary-element-text);
background-color: var(--color-primary-element);
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;

.icon {
display: inline-block;
vertical-align: middle;
margin-bottom: 2px;
margin-right: 4px;

&.icon-invert {
filter: invert(1);
}
}

&:hover,
&:focus,
&:active {
background-color: var(--color-primary-element-light);
}
.icon {
filter: var(--primary-invert-if-dark);
}
</style>
Loading
Loading