Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] Setup check migrations to new API #42918

Merged
merged 13 commits into from
Jan 18, 2024
Merged

[stable28] Setup check migrations to new API #42918

merged 13 commits into from
Jan 18, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Jan 18, 2024 •
edited
Loading

See #41364

Summary

Backport:

Checklist

come-nc added 13 commits January 18, 2024 09:54
@come-nc
Migrate code integrity to SetupCheck API
e35fa73 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Use highlight rich objecttype to render links in CodeIntegrity setup …
44b8cf6 
…check

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Improve validator output in case of invalid RichObject
985a91c 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Properly escape HTML and add support for highlight links in setupchecks
a59dcd4 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Remove CSRF check from code integrity rescan
7305fd7 
Did not find a way to get a valid token from SetupCheck

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Fix tests in CheckSetupControllerTest
6e86870 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Fix tests because we added escaping to setupchecks
956d7ae 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Migrate overwrite.cli.url setup check to new API
2bc1f78 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Fix CheckSetupControllerTest following overwrite.cli.url migration
86bfd73 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Migrate Cron checks to new SetupCheck API
27514ad 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Fix Cron setup check tests
d5c9d60 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Remove references to removed functions in tests
19aaaad 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Remove obsolete check of curl SSL version
f9eeb28 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added the 3. to review Waiting for reviews label Jan 18, 2024
@come-nc come-nc added this to the Nextcloud 28.0.2 milestone Jan 18, 2024
@come-nc come-nc self-assigned this Jan 18, 2024
@come-nc come-nc mentioned this pull request Jan 18, 2024
Closed
33 tasks
@come-nc come-nc requested review from a team, ArtificialOwl, icewind1991 and sorbaugh and removed request for a team January 18, 2024 09:25
@come-nc come-nc marked this pull request as ready for review January 18, 2024 09:39
@blizzz blizzz mentioned this pull request Jan 18, 2024
Merged
@blizzz blizzz merged commit b692fbf into stable28 Jan 18, 2024
52 checks passed
@blizzz blizzz deleted the backport/setupchecks-2/stable28 branch January 18, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-backend

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 28.0.2
Development

Successfully merging this pull request may close these issues.
4 participants
@come-nc @AndyScherzinger @artonge @blizzz