[stable28] fix(settings): Disable renaming for tokens marked to be wiped #43195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
This otherwise a WipeException will be thrown when trying to rename Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -105,7 +105,7 @@ | |||
| return array_map(function (IToken $token) use ($sessionToken) { | |||
| $data = $token->jsonSerialize(); | |||
| $data['canDelete'] = true; | |||
| $data['canRename'] = $token instanceof INamedToken; | |||
| $data['canRename'] = $token instanceof INamedToken && $data['type'] !== IToken::WIPE_TOKEN; | |||
Check notice
Code scanning / Psalm
DeprecatedClass Note
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
backport/42331/stable28
branch
from
b1a0663 to
a61c11f
Compare
susnux
approved these changes
Jan 29, 2024
emoral435
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #42331
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.